Skip to content

generic compat_sys_sysctl

Eric W. Biederman linux-arch lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11sysctl: Separate the binary sysctl logic into it's own file.kernel/Makefile kernel/sysctl.c kernel/sysctl_binary.c+185 -1656 replies
2/11sysctl: Refactor the binary sysctl handling to remove duplicate codekernel/sysctl_binary.c+58 -650 replies
3/11sysctl: Introduce a generic compat sysctl sysctlarch/powerpc/kernel/sys_ppc32.c kernel/sysctl_binary.c+50 -520 replies
4/11sysctl: ia64 Use the compat_sys_sysctlarch/ia64/ia32/ia32_entry.S arch/ia64/ia32/sys_ia32.c+1 -560 replies
5/11sysctl: mips Use the compat_sys_sysctlarch/mips/kernel/linux32.c arch/mips/kernel/scall64-n32.S arch/mips/kernel/scall64-o32.S+2 -630 replies
6/11sysctl: parisc Use the compat_sys_sysctlarch/parisc/kernel/sys_parisc32.c arch/parisc/kernel/syscall_table.S+1 -721 reply
7/11sysctl: s390 Use the compat_sys_sysctlarch/s390/kernel/compat_linux.c arch/s390/kernel/compat_linux.h arch/s390/kernel/compat_wrapper.S+2 -593 replies
8/11sysctl: sparc Use the compat_sys_sysctlarch/sparc/kernel/sys_sparc32.c arch/sparc/kernel/systbls_64.S+1 -581 reply
9/11sysctl: x86 Use the compat_sys_sysctlarch/x86/ia32/ia32entry.S arch/x86/ia32/sys_ia32.c arch/x86/include/asm/sys_ia32.h+1 -622 replies
10/11sysctl: Remove the cond_syscall entry for sys32_sysctlkernel/sys_ni.c+0 -10 replies
11/11sysctl: Make do_sysctl staticinclude/linux/sysctl.h kernel/sysctl_binary.c+1 -50 replies

Reviews trailers per patch

4 of 11 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchH. Peter AnvinDavid S. MillerKyle McMartinChristian BorntraegerMartin SchwidefskyArnd Bergmann
SeriesA-b
1/11
2/11
3/11
4/11
5/11
6/11A-b
7/11A-b A-b
8/11A-b
9/11A-b
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 0/11] generic compat_sys_sysctl

I am in the process of cleaning up, and converting the binary sysctl sysctl call into a wrapper on top of the text based proc/sys.

A first step in that process is to introduce a generic compat_sys_sysctl to reduce the number of places I have to touch. The following patcheset is the start of my series for handling that.

The only architecture specific changes should be replace the current architecture name for it's 32bit compat syscall with compat_sys_sysctl, and deleting the architectures private 32bit compat syscall. The only requirement is that CONFIG_COMPAT be set when you need compat_sys_sysctl.

These patches should just work, but an eyeball from someone who is familiar with the architecture specific details would be appreciated. I have only tested the 32bit compat code on x86_64.

Eric