Skip to content

tty layer and misc struct pid conversions

Eric W. Biederman lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12tty: Make __proc_set_tty static.drivers/char/tty_io.c include/linux/tty.h+2 -20 replies
2/12tty: Clarify disassociate_cttydrivers/char/tty_io.c+6 -20 replies
3/12tty: Fix the locking for signal->session in disassociate_cttydrivers/char/tty_io.c+1 -30 replies
4/12signal: Use kill_pgrp not kill_pg in the sunos compatibility code.arch/sparc/kernel/sys_sunos.c arch/sparc64/kernel/sys_sunos32.c+15 -60 replies
5/12signal: Rewrite kill_something_info so it uses newer helpers.kernel/signal.c+8 -40 replies
6/12pid: Make session_of_pgrp use struct pid instead of pid_t.drivers/char/tty_io.c include/linux/kernel.h kernel/exit.c+26 -170 replies
7/12pid: Use struct pid for talking about process groups in exit.ckernel/exit.c+22 -200 replies
8/12pid: Replace is_orphaned_pgrp with is_current_pgrp_orphaneddrivers/char/n_tty.c drivers/char/tty_io.c include/linux/tty.h +2 more+6 -60 replies
9/12tty: Update the tty layer to work with struct pid.arch/um/drivers/line.c drivers/char/ip2/ip2main.c drivers/char/n_tty.c +8 more+95 -690 replies
10/12pid: Replace do/while_each_task_pid with do/while_each_pid_taskfs/ioprio.c kernel/capability.c kernel/sys.c+41 -250 replies
11/12pid: Remove now unused do_each_task_pid and while_each_task_pidinclude/linux/pid.h+0 -140 replies
12/12pid: Remove the now unused kill_pg kill_pg_info and __kill_pg_infoinclude/linux/sched.h kernel/signal.c+0 -300 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/12] tty layer and misc struct pid conversions

The aim of this patch set is to start wrapping up the struct pid conversions. As such this patchset culminates with the removal of kill_pg, kill_pg_info, __kill_pg_info, do_each_task_pid, and while_each_task_pid.

kill_proc, daemonize, and kernel_thread are still in my sights but there is still work to get to them.

The first three are basic cleanups around disassociate_ctty, while working on converting it I found several issues. tty_old_pgrp can be a tricky concept to wrap your head around.

1 tty: Make __proc_set_tty static.
2 tty: Clarify disassociate_ctty
3 tty: Fix the locking for signal->session in disassociate_ctty

These just stop using the old helper functions.

4 signal: Use kill_pgrp not kill_pg in the sunos compatibility code. 5 signal: Rewrite kill_something_info so it uses newer helpers.

Then the grind to convert the tty layer and all of it's helper functions to struct pid.

6 pid: Make session_of_pgrp use struct pid instead of pid_t. 7 pid: Use struct pid for talking about process groups in exit.c 8 pid: Replace is_orphaned_pgrp with is_current_pgrp_orphaned 9 tty: Update the tty layer to work with struct pid.

A final helper function update.

10 pid: Replace do/while_each_task_pid with do/while_each_pid_task

And the removal of the functions that are now unused.
11 pid: Remove now unused do_each_task_pid and while_each_task_pid 12 pid: Remove the now unused kill_pg kill_pg_info and __kill_pg_info

All of these should be fairly simple and to the point.

Eric