sysfs cleanups.
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest24 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | sysfs: Implement sysfs_rename_linkfs/ include/ | +25 | 0 replies | |
| 2/24 | driver core: Use sysfs_rename_link in device_renamedrivers/ | +6 | 0 replies | |
| 3/24 | sysfs: Remove now unnecessary error reporting suppression.fs/ fs/ fs/ | +21 | 0 replies | |
| 4/24 | sysfs: Normalize removing sysfs directories.fs/ | +44 | 11 replies | |
| 5/24 | sysfs: Rename sysfs_d_iput to sysfs_dentry_iputfs/ | +2 | 0 replies | |
| 6/24 | sysfs: Use dentry_ops instead of directly playing with the dcachefs/ | +46 | 0 replies | |
| 7/24 | sysfs: Simplify sysfs_chmod_file semanticsfs/ | +1 | 0 replies | |
| 8/24 | sysfs: Optimize just changing the sysfs file mode.fs/ | +14 | 0 replies | |
| 9/24 | sysfs: Simplify iattr assignmentsfs/ | +3 | 0 replies | |
| 10/24 | sysfs: Fix locking and factor out sysfs_sd_setattrfs/ fs/ | +31 | 0 replies | |
| 11/24 | sysfs: Update s_iattr on link and unlink.fs/ | +14 | 0 replies | |
| 12/24 | sysfs: Nicely indent sysfs_symlink_inode_operationsfs/ | +3 | 0 replies | |
| 13/24 | sysfs: Implement sysfs_getattr & sysfs_permissionfs/ fs/ fs/ +1 more | +49 | 0 replies | |
| 14/24 | sysfs: In sysfs_chmod_file lazily propagate the mode change.fs/ | +8 | 0 replies | |
| 15/24 | sysfs: Kill sysfs_addrm_start and sysfs_addrm_finishfs/ fs/ fs/ +2 more | +32 | 0 replies | |
| 16/24 | sysfs: Propagate renames to the vfs on demandfs/ fs/ fs/ +2 more | +32 | 0 replies | |
| 17/24 | sysfs: Merge sysfs_rename_dir and sysfs_move_dirfs/ | +28 | 0 replies | |
| 18/24 | sysfs: Pass super_block to sysfs_get_inodefs/ fs/ fs/ +1 more | +6 | 0 replies | |
| 19/24 | sysfs: Kill unused sysfs_sb variable.fs/ fs/ | +0 | 0 replies | |
| 20/24 | sysfs: Normalize error handling in sysfs_fill_inodefs/ | +11 | 0 replies | |
| 21/24 | sysfs: Rename sysfs_mv_dir sysfs_renamefs/ fs/ | +6 | 0 replies | |
| 22/24 | sysfs: Make sysfs_rename_link atomicfs/ | +24 | 3 replies | |
| 23/24 | driver core: Don't remove kobjects in device_shutdown.drivers/ | +0 | 0 replies | |
| 24/24 | sysfs: In sysfs_add_one fail if the targe directory has been removed.fs/ | +22 | 1 reply |
Reviews trailers per patch
18 of 24 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Tejun Heo | Kay Sievers |
|---|---|---|
| Series | A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b | A-b A-b A-b |
| 1/24 | ||
| 2/24 | ||
| 3/24 | ||
| 4/24 | ||
| 5/24 | A-b | |
| 6/24 | A-b | |
| 7/24 | A-b | |
| 8/24 | ||
| 9/24 | A-b | |
| 10/24 | A-b | |
| 11/24 | A-b | |
| 12/24 | A-b | |
| 13/24 | A-b | |
| 14/24 | A-b | |
| 15/24 | A-b | |
| 16/24 | A-b | |
| 17/24 | A-b | |
| 18/24 | A-b | |
| 19/24 | A-b | |
| 20/24 | A-b | |
| 21/24 | ||
| 22/24 | A-b | A-b |
| 23/24 | A-b | |
| 24/24 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/24] sysfs cleanups.
Quoted 8 lines · Greg KH
Quoted 7 lines
Quoted 2 lines
Or are there still problems, like the "fry the ext3 boot partition" that Kay found?
That is unrelated to Eric's patches, They just added the dump, which I tried to trigger. It's not entirely clear what caused the filesytem damage, but I was definitely able to reproduce the unclean shutdown without any of Eric's sysfs patches.
Quoted 4 lines
Ok.
But I think Eric had some updates to some of the patches along the way, so a whole new respin would be good to ensure I get the correct ones.
Ok. Here is my respun patchset. I have not changed which files we remove in a directory when we remove a non-empty directory. Leaving that issue to be addressed another time.
To accommodate that I have respun two patches:
patch 4 sysfs: Normalize removing sysfs directories. patch 15 sysfs: Kill sysfs_addrm_start and sysfs_addrm_finish
Killing addrm is only changed to track the previous differences.
Eric