Skip to content

sysfs cleanups.

Eric W. Biederman linux-fsdevel linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24sysfs: Implement sysfs_rename_linkfs/sysfs/symlink.c include/linux/sysfs.h+25 -00 replies
2/24driver core: Use sysfs_rename_link in device_renamedrivers/base/core.c+6 -120 replies
3/24sysfs: Remove now unnecessary error reporting suppression.fs/sysfs/dir.c fs/sysfs/symlink.c fs/sysfs/sysfs.h+21 -760 replies
4/24sysfs: Normalize removing sysfs directories.fs/sysfs/dir.c+44 -1811 replies
5/24sysfs: Rename sysfs_d_iput to sysfs_dentry_iputfs/sysfs/dir.c+2 -20 replies
6/24sysfs: Use dentry_ops instead of directly playing with the dcachefs/sysfs/dir.c+46 -270 replies
7/24sysfs: Simplify sysfs_chmod_file semanticsfs/sysfs/file.c+1 -90 replies
8/24sysfs: Optimize just changing the sysfs file mode.fs/sysfs/inode.c+14 -80 replies
9/24sysfs: Simplify iattr assignmentsfs/sysfs/inode.c+3 -60 replies
10/24sysfs: Fix locking and factor out sysfs_sd_setattrfs/sysfs/inode.c fs/sysfs/sysfs.h+31 -220 replies
11/24sysfs: Update s_iattr on link and unlink.fs/sysfs/dir.c+14 -00 replies
12/24sysfs: Nicely indent sysfs_symlink_inode_operationsfs/sysfs/symlink.c+3 -30 replies
13/24sysfs: Implement sysfs_getattr & sysfs_permissionfs/sysfs/dir.c fs/sysfs/inode.c fs/sysfs/symlink.c +1 more+49 -120 replies
14/24sysfs: In sysfs_chmod_file lazily propagate the mode change.fs/sysfs/file.c+8 -230 replies
15/24sysfs: Kill sysfs_addrm_start and sysfs_addrm_finishfs/sysfs/dir.c fs/sysfs/file.c fs/sysfs/inode.c +2 more+32 -2010 replies
16/24sysfs: Propagate renames to the vfs on demandfs/namei.c fs/sysfs/dir.c fs/sysfs/inode.c +2 more+32 -1600 replies
17/24sysfs: Merge sysfs_rename_dir and sysfs_move_dirfs/sysfs/dir.c+28 -380 replies
18/24sysfs: Pass super_block to sysfs_get_inodefs/sysfs/dir.c fs/sysfs/inode.c fs/sysfs/mount.c +1 more+6 -50 replies
19/24sysfs: Kill unused sysfs_sb variable.fs/sysfs/mount.c fs/sysfs/sysfs.h+0 -30 replies
20/24sysfs: Normalize error handling in sysfs_fill_inodefs/sysfs/mount.c+11 -50 replies
21/24sysfs: Rename sysfs_mv_dir sysfs_renamefs/sysfs/dir.c fs/sysfs/sysfs.h+6 -30 replies
22/24sysfs: Make sysfs_rename_link atomicfs/sysfs/symlink.c+24 -23 replies
23/24driver core: Don't remove kobjects in device_shutdown.drivers/base/core.c+0 -30 replies
24/24sysfs: In sysfs_add_one fail if the targe directory has been removed.fs/sysfs/dir.c+22 -131 reply

Reviews trailers per patch

18 of 24 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTejun HeoKay Sievers
SeriesA-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b
1/24
2/24
3/24
4/24
5/24A-b
6/24A-b
7/24A-b
8/24
9/24A-b
10/24A-b
11/24A-b
12/24A-b
13/24A-b
14/24A-b
15/24A-b
16/24A-b
17/24A-b
18/24A-b
19/24A-b
20/24A-b
21/24
22/24A-b A-b
23/24A-b
24/24A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/24] sysfs cleanups.
Quoted 8 lines · Greg KH
Quoted 7 lines
Quoted 2 lines

Or are there still problems, like the "fry the ext3 boot partition" that Kay found?

That is unrelated to Eric's patches, They just added the dump, which I tried to trigger. It's not entirely clear what caused the filesytem damage, but I was definitely able to reproduce the unclean shutdown without any of Eric's sysfs patches.

Quoted 4 lines

Ok.

But I think Eric had some updates to some of the patches along the way, so a whole new respin would be good to ensure I get the correct ones.

Ok. Here is my respun patchset. I have not changed which files we remove in a directory when we remove a non-empty directory. Leaving that issue to be addressed another time.

To accommodate that I have respun two patches:

patch 4 sysfs: Normalize removing sysfs directories. patch 15 sysfs: Kill sysfs_addrm_start and sysfs_addrm_finish

Killing addrm is only changed to track the previous differences.

Eric