Skip to content

Intel FB: cleanup and misc interlaced mode support

Krzysztof Halasa lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Intel FB: whitespace, bracket and other clean-upsdrivers/video/intelfb/intelfb.h drivers/video/intelfb/intelfb_i2c.c drivers/video/intelfb/intelfbdrv.c +2 more+202 -2520 replies
2/4Intel FB: obvious changes and correctionsdrivers/video/intelfb/intelfb.h drivers/video/intelfb/intelfbhw.c drivers/video/intelfb/intelfbhw.h+13 -100 replies
3/4Intel FB: force even line count in interlaced modedrivers/video/intelfb/intelfbhw.c+15 -00 replies
4/4Intel FB: more interlaced mode supportdrivers/video/intelfb/intelfbhw.c drivers/video/intelfb/intelfbhw.h include/linux/fb.h+82 -400 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Intel FB: cleanup and misc interlaced mode support

Hi,

I'll attach 4 patches for Intel FB (i830+) here:

1/4 - whitespace, bracket and other clean-ups (rather long)
working with kernel-style brackets instead of:
----------------
void
function_name (int arg) {
----------------
is a bit easier. I think it would be best to apply it in the beginning of the "patch period" to avoid potential conflicts.

2/4 - obvious changes and corrections

3/4 - the chip adds two halflines automatically in interlaced mode,
we have to force the number of lines to be even

4/4 - allow odd- and even-field-first in interlaced modes, and
proper sync to vertical retrace. It enables video players (got it working with MPlayer currently) to play perfect field-synced stream to RGB-connected (VGA output) TV set.

This patch adds #define FB_VMODE_ODD_FLD_FIRST 4 in include/linux/fb.h, to be able to force odd field first (analog broadcast PAL and some PAL DVD discs use it) instead of even field (bottom) first, as used by NTSC, DV PAL, some PAL DVDs etc. Interlaced-only thing.

This change need a coresponding change in fbset and probably in media players which want to set video mode themselves, I will do the fbset part and maybe MPlayer's if the fb.h patch is ok.

All four patches change only files in drivers/video/intelfb/, except patch 4/4 which also adds FB_VMODE_ODD_FLD_FIRST in include/linux/fb.h.

Tested on i915G in 1440x576 50 Hz (I) with PAL TV.

Signature · 1 line
Krzysztof Halasa