Skip to content

RFC ref-filter: performance optimization

ZheNing Hu via GitGitGadget git 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 0 repliesNew

Changes in this patch series from the cover letter

1. Skip parse_object_buffer(), which can reduce object content parsing.
2. Use linked list to record parsing results, which can reduce second format string parsing.
3. Reuse final buffer, which can reduce memcpy();
4. Add a need_get_object_info flag instead of compare two object_info,

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ref-filter: skip parse_object_buffer in some casesref-filter.c ref-filter.h+40 -140 replies
2/5ref-filter: remove second parsing in format_ref_array_itembuiltin/branch.c builtin/for-each-ref.c builtin/tag.c +3 more+55 -100 replies
3/5ref-filter: reuse final bufferref-filter.c ref-filter.h+36 -60 replies
4/5ref-filter: reduce unnecessary object_info comparisonsref-filter.c+23 -110 replies
5/5: ref-filter: instead CALLOC_ARRAY to ALLOC_ARRAYref-filter.c+2 -10 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchChristian CouderHariom Verma
1/5Mentored-by Mentored-by
2/5Mentored-by Mentored-by
3/5Mentored-by Mentored-by
4/5Mentored-by Mentored-by
5/5Mentored-by Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] [GSOC] [RFC] ref-filter: performance optimization

Last time I submitted a very long patch series:
https://lore.kernel.org/git/[email protected]/
My mentor Christian suggested to split the performance optimization part out, so this patch series used to optimize performance optimization in ref-filter.

Changes in this patch series:

1. Skip parse_object_buffer(), which can reduce object content parsing.
2. Use linked list to record parsing results, which can reduce second format string parsing.
3. Reuse final buffer, which can reduce memcpy();
4. Add a need_get_object_info flag instead of compare two object_info,

    which can reduce memcmp();

5. Use ALLOC_ARRAY() instead of CALLOC_ARRAY(), which can reduce memset();

Since the relevant part of git cat-file --batch has been deleted, the execution time of git for-each-ref is very short, I haven’t added performance tests yet for git for-each-ref.

ZheNing Hu (5):
[GSOC] ref-filter: skip parse_object_buffer in some cases [GSOC] ref-filter: remove second parsing in format_ref_array_item [GSOC] ref-filter: reuse final buffer
[GSOC] ref-filter: reduce unnecessary object_info comparisons [GSOC]: ref-filter: instead CALLOC_ARRAY to ALLOC_ARRAY

 builtin/branch.c       |   2 +
 builtin/for-each-ref.c |   3 +-
 builtin/tag.c          |   2 +
 builtin/verify-tag.c   |   2 +
 ref-filter.c           | 168 ++++++++++++++++++++++++++++++++---------
 ref-filter.h           |  17 ++++-
 6 files changed, 154 insertions(+), 40 deletions(-)

base-commit: f000ecbed922c727382651490e75014f003c89ca
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1020%2Fadlternative%2Fref-filter-opt-perf-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1020/adlternative/ref-filter-opt-perf-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1020

Signature · 1 line
gitgitgadget