Skip to content

pull: release handles to pack files before potentially gc'ing

Johannes Schindelin via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2commit-graph: when closing the graph, also release the slabcommit-graph.c+1 -00 replies
2/2pull: release packs before fetchingbuiltin/pull.c+2 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] pull: release handles to pack files before potentially gc'ing

It was reported in Git for Windows
[https://github.com/git-for-windows/git/issues/3336] that there are still some code paths where .pack files are still open when a garbage collection is triggered. This time, the affected command is git pull.

The fix is relatively trivial but uncovers a bug in the commit-graph code, which we have to fix first.

Johannes Schindelin (2):
commit-graph: when closing the graph, also release the slab
pull: release packs before fetching

 builtin/pull.c | 2 ++
 commit-graph.c | 1 +
 2 files changed, 3 insertions(+)

base-commit: 225bc32a989d7a22fa6addafd4ce7dcd04675dbf
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1032%2Fdscho%2Frelease-packs-before-fetching-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1032/dscho/release-packs-before-fetching-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1032

Signature · 1 line
gitgitgadget