Skip to content

Builtin FSMonitor Part 2

Jeff Hostetler via GitGitGadget git 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest30 patches 6 repliesIn review
  2. v830 patches 8 repliesSuperseded
  3. v729 patches 8 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v630 patches24 repliesSuperseded
v530 patches33 repliesSuperseded
v429 patches10 repliesSuperseded
v35 patches2 repliesSuperseded
v2 posting 2/25 patches2 repliesSuperseded
v2 posting 1/27 patches24 repliesSuperseded
v15 patches3 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/30fsmonitor: enhance existing comments, clarify trivial response handlingfsmonitor.c+41 -230 replies
2/30fsmonitor-ipc: create client routines for git-fsmonitor--daemonMakefile fsmonitor-ipc.c fsmonitor-ipc.h+220 -00 replies
3/30fsmonitor: config settings are repository-specificMakefile builtin/update-index.c cache.h +9 more+196 -490 replies
4/30fsmonitor: use IPC to query the builtin FSMonitor daemonfsmonitor.c+36 -20 replies
5/30fsmonitor: document builtin fsmonitorDocumentation/config/core.txt Documentation/git-fsmonitor--daemon.txt Documentation/git-update-index.txt+126 -170 replies
6/30fsmonitor--daemon: add a built-in fsmonitor daemon.gitignore Makefile builtin.h +2 more+50 -00 replies
7/30fsmonitor--daemon: implement 'stop' and 'status' commandsbuiltin/fsmonitor--daemon.c+51 -00 replies
8/30compat/fsmonitor/fsm-listen-win32: stub in backend for WindowsMakefile compat/fsmonitor/fsm-listen-win32.c compat/fsmonitor/fsm-listen.h +3 more+101 -00 replies
9/30compat/fsmonitor/fsm-listen-darwin: stub in backend for Darwincompat/fsmonitor/fsm-listen-darwin.c config.mak.uname contrib/buildsystems/CMakeLists.txt+33 -00 replies
10/30fsmonitor--daemon: implement 'run' commandbuiltin/fsmonitor--daemon.c fsmonitor--daemon.h+261 -10 replies
11/30fsmonitor--daemon: implement 'start' commandbuiltin/fsmonitor--daemon.c+107 -20 replies
12/30fsmonitor--daemon: add pathname classificationbuiltin/fsmonitor--daemon.c fsmonitor--daemon.h+168 -00 replies
13/30fsmonitor--daemon: define token-idsbuiltin/fsmonitor--daemon.c+115 -10 replies
14/30fsmonitor--daemon: create token-based changed path cachebuiltin/fsmonitor--daemon.c fsmonitor--daemon.h+268 -20 replies
15/30compat/fsmonitor/fsm-listen-win32: implement FSMonitor backend on Windowscompat/fsmonitor/fsm-listen-win32.c+565 -00 replies
16/30compat/fsmonitor/fsm-listen-darwin: add MacOS header files for FSEventcompat/fsmonitor/fsm-darwin-gcc.h compat/fsmonitor/fsm-listen-darwin.c+116 -00 replies
17/30compat/fsmonitor/fsm-listen-darwin: implement FSEvent listener on MacOScompat/fsmonitor/fsm-listen-darwin.c+383 -00 replies
18/30fsmonitor--daemon: implement handle_client callbackbuiltin/fsmonitor--daemon.c+309 -20 replies
19/30help: include fsmonitor--daemon feature flag in version infohelp.c t/test-lib.sh+11 -00 replies
20/30t/helper/fsmonitor-client: create IPC client to talk to FSMonitor DaemonMakefile t/helper/test-fsmonitor-client.c t/helper/test-tool.c +1 more+119 -00 replies
21/30t7527: create test for fsmonitor--daemont/t7527-builtin-fsmonitor.sh+494 -00 replies
22/30t/perf: avoid copying builtin fsmonitor files into test repot/perf/perf-lib.sh+1 -10 replies
23/30t/helper/test-chmtime: skip directories on Windowst/helper/test-chmtime.c+15 -00 replies
24/30t/perf/p7519: fix coding stylet/perf/p7519-fsmonitor.sh+4 -40 replies
25/30t/perf/p7519: speed up test on Windowst/perf/p7519-fsmonitor.sh+16 -80 replies
26/30t/perf/p7519: add fsmonitor--daemon test casest/perf/p7519-fsmonitor.sh+34 -40 replies
27/30fsmonitor--daemon: periodically truncate list of modified filesbuiltin/fsmonitor--daemon.c+88 -00 replies
28/30fsmonitor--daemon: use a cookie file to sync with file systembuiltin/fsmonitor--daemon.c fsmonitor--daemon.h+241 -10 replies
29/30fsmonitor: force update index after large responsesfsmonitor.c+54 -10 replies
30/30t7527: test status with untracked-cache and fsmonitor--daemont/t7527-builtin-fsmonitor.sh+115 -00 replies

Reviews trailers per patch

None of the 30 patches has a Reviewed-by or Acked-by.

PatchKevin WillfordJohannes Schindelin
1/30
2/30
3/30
4/30
5/30
6/30Co-authored-by
7/30
8/30
9/30
10/30
11/30
12/30
13/30
14/30
15/30
16/30
17/30Co-authored-by Co-authored-by
18/30
19/30
20/30
21/30
22/30
23/30
24/30
25/30
26/30
27/30
28/30Co-authored-by Co-authored-by
29/30
30/30

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 00/30] Builtin FSMonitor Part 2

Here is V9 of Part 2 of my builtin FSMonitor series. This version addresses bash style issues in t7527 raised on V8. These changes do not require a new version of Part 3.

Here is a range-diff from V8 to V9 relative to 715d08a9e5 (The eighth batch, 2022-02-25).

 1:  e98373f997 =  1:  e98373f997 fsmonitor: enhance existing comments, clarify trivial response handling
 2:  ab68b94417 =  2:  ab68b94417 fsmonitor-ipc: create client routines for git-fsmonitor--daemon
 3:  e04c7301f2 =  3:  e04c7301f2 fsmonitor: config settings are repository-specific
 4:  ea02ba25d8 =  4:  ea02ba25d8 fsmonitor: use IPC to query the builtin FSMonitor daemon
 5:  6ab7db9cb7 =  5:  6ab7db9cb7 fsmonitor: document builtin fsmonitor
 6:  0ce8ae3f2c =  6:  0ce8ae3f2c fsmonitor--daemon: add a built-in fsmonitor daemon
 7:  4624ce2fa4 =  7:  4624ce2fa4 fsmonitor--daemon: implement 'stop' and 'status' commands
 8:  a29fe7266a =  8:  a29fe7266a compat/fsmonitor/fsm-listen-win32: stub in backend for Windows
 9:  2f8a42fdb9 =  9:  2f8a42fdb9 compat/fsmonitor/fsm-listen-darwin: stub in backend for Darwin
10:  f07800690e = 10:  f07800690e fsmonitor--daemon: implement 'run' command
11:  a6a39a3306 = 11:  a6a39a3306 fsmonitor--daemon: implement 'start' command
12:  d62e338d00 = 12:  d62e338d00 fsmonitor--daemon: add pathname classification
13:  53e06b4ae5 = 13:  53e06b4ae5 fsmonitor--daemon: define token-ids
14:  39f43fabe0 = 14:  39f43fabe0 fsmonitor--daemon: create token-based changed path cache
15:  239558e34f = 15:  239558e34f compat/fsmonitor/fsm-listen-win32: implement FSMonitor backend on Windows
16:  14b775e9d8 = 16:  14b775e9d8 compat/fsmonitor/fsm-listen-darwin: add MacOS header files for FSEvent
17:  55bd7aee06 = 17:  55bd7aee06 compat/fsmonitor/fsm-listen-darwin: implement FSEvent listener on MacOS
18:  c43009124f = 18:  c43009124f fsmonitor--daemon: implement handle_client callback
19:  ed338777b5 = 19:  ed338777b5 help: include fsmonitor--daemon feature flag in version info
20:  c99bac29d4 = 20:  c99bac29d4 t/helper/fsmonitor-client: create IPC client to talk to FSMonitor Daemon
21:  c8709da945 ! 21:  bc94e379b0 t7527: create test for fsmonitor--daemon
    @@ Commit message
         t7527: create test for fsmonitor--daemon
     
         Signed-off-by: Jeff Hostetler <[email protected]>
    -    Signed-off-by: Junio C Hamano <[email protected]>
     
      ## t/t7527-builtin-fsmonitor.sh (new) ##
     @@
    @@ t/t7527-builtin-fsmonitor.sh (new)
     +    rm -rf $1
     +}
     +
    -+is_value () {
    -+    test -n "$1" && test "${1::1}" != "-"
    -+}
    -+
     +start_daemon () {
    -+    r= &&
    -+    tf= &&
    -+    t2= &&
    -+    tk= &&
    ++    r= tf= t2= tk= &&
     +
     +    while test "$#" -ne 0
     +    do
     +        case "$1" in
     +        -C)
    -+            shift;
    -+            is_value $1 || BUG "error: -C requires value"
    -+            r="-C $1"
    ++            r="-C ${2?}"
     +            shift
     +            ;;
     +        --tf)
    -+            shift;
    -+            is_value $1 || BUG "error: --tf requires value"
    -+            tf="$1"
    ++            tf="${2?}"
     +            shift
     +            ;;
     +        --t2)
    -+            shift;
    -+            is_value $1 || BUG "error: --t2 requires value"
    -+            t2="$1"
    ++            t2="${2?}"
     +            shift
     +            ;;
     +        --tk)
    -+            shift;
    -+            is_value $1 || BUG "error: --tk requires value"
    -+            tk="$1"
    ++            tk="${2?}"
     +            shift
     +            ;;
    -+        *)
    ++        -*)
     +            BUG "error: unknown option: '$1'"
     +            ;;
    ++        *)
    ++            BUG "error: unbound argument: '$1'"
    ++            ;;
     +        esac
    ++        shift
     +    done &&
     +
     +    (
22:  cc39ecf10a = 22:  06d56d3a73 t/perf: avoid copying builtin fsmonitor files into test repo
23:  2bb3eb8476 = 23:  2dd0215127 t/helper/test-chmtime: skip directories on Windows
24:  bab9a9b080 = 24:  bb88cddc13 t/perf/p7519: fix coding style
25:  2dd06ad2f7 = 25:  50c2afaa49 t/perf/p7519: speed up test on Windows
26:  6eaa5765ae = 26:  5b18e3b692 t/perf/p7519: add fsmonitor--daemon test cases
27:  30957f3930 = 27:  899c23f63c fsmonitor--daemon: periodically truncate list of modified files
28:  c8ca2a1727 = 28:  597a7192f9 fsmonitor--daemon: use a cookie file to sync with file system
29:  4caf1d89b8 = 29:  68a05fd289 fsmonitor: force update index after large responses
30:  f87a1eba69 = 30:  5eb696daba t7527: test status with untracked-cache and fsmonitor--daemon

Jeff Hostetler (30):
fsmonitor: enhance existing comments, clarify trivial response
handling
fsmonitor-ipc: create client routines for git-fsmonitor--daemon
fsmonitor: config settings are repository-specific
fsmonitor: use IPC to query the builtin FSMonitor daemon
fsmonitor: document builtin fsmonitor
fsmonitor--daemon: add a built-in fsmonitor daemon
fsmonitor--daemon: implement 'stop' and 'status' commands compat/fsmonitor/fsm-listen-win32: stub in backend for Windows compat/fsmonitor/fsm-listen-darwin: stub in backend for Darwin
fsmonitor--daemon: implement 'run' command
fsmonitor--daemon: implement 'start' command
fsmonitor--daemon: add pathname classification
fsmonitor--daemon: define token-ids
fsmonitor--daemon: create token-based changed path cache compat/fsmonitor/fsm-listen-win32: implement FSMonitor backend on
Windows
compat/fsmonitor/fsm-listen-darwin: add MacOS header files for FSEvent compat/fsmonitor/fsm-listen-darwin: implement FSEvent listener on
MacOS
fsmonitor--daemon: implement handle_client callback
help: include fsmonitor--daemon feature flag in version info t/helper/fsmonitor-client: create IPC client to talk to FSMonitor
Daemon
t7527: create test for fsmonitor--daemon
t/perf: avoid copying builtin fsmonitor files into test repo t/helper/test-chmtime: skip directories on Windows t/perf/p7519: fix coding style
t/perf/p7519: speed up test on Windows
t/perf/p7519: add fsmonitor--daemon test cases
fsmonitor--daemon: periodically truncate list of modified files
fsmonitor--daemon: use a cookie file to sync with file system
fsmonitor: force update index after large responses
t7527: test status with untracked-cache and fsmonitor--daemon

 .gitignore                              |    1 +
 Documentation/config/core.txt           |   60 +-
 Documentation/git-fsmonitor--daemon.txt |   75 ++
 Documentation/git-update-index.txt      |    8 +-
 Makefile                                |   17 +
 builtin.h                               |    1 +
 builtin/fsmonitor--daemon.c             | 1479 +++++++++++++++++++++++
 builtin/update-index.c                  |    7 +-
 cache.h                                 |    1 -
 compat/fsmonitor/fsm-darwin-gcc.h       |   92 ++
 compat/fsmonitor/fsm-listen-darwin.c    |  427 +++++++
 compat/fsmonitor/fsm-listen-win32.c     |  586 +++++++++
 compat/fsmonitor/fsm-listen.h           |   49 +
 config.c                                |   14 -
 config.h                                |    1 -
 config.mak.uname                        |   20 +
 contrib/buildsystems/CMakeLists.txt     |   10 +
 environment.c                           |    1 -
 fsmonitor--daemon.h                     |  166 +++
 fsmonitor-ipc.c                         |  171 +++
 fsmonitor-ipc.h                         |   48 +
 fsmonitor-settings.c                    |  114 ++
 fsmonitor-settings.h                    |   21 +
 fsmonitor.c                             |  216 +++-
 fsmonitor.h                             |   15 +-
 git.c                                   |    1 +
 help.c                                  |    4 +
 repo-settings.c                         |    1 +
 repository.h                            |    3 +
 t/README                                |    4 +-
 t/helper/test-chmtime.c                 |   15 +
 t/helper/test-fsmonitor-client.c        |  116 ++
 t/helper/test-tool.c                    |    1 +
 t/helper/test-tool.h                    |    1 +
 t/perf/p7519-fsmonitor.sh               |   68 +-
 t/perf/perf-lib.sh                      |    2 +-
 t/t7527-builtin-fsmonitor.sh            |  609 ++++++++++
 t/test-lib.sh                           |    7 +
 38 files changed, 4326 insertions(+), 106 deletions(-)
 create mode 100644 Documentation/git-fsmonitor--daemon.txt
 create mode 100644 builtin/fsmonitor--daemon.c
 create mode 100644 compat/fsmonitor/fsm-darwin-gcc.h
 create mode 100644 compat/fsmonitor/fsm-listen-darwin.c
 create mode 100644 compat/fsmonitor/fsm-listen-win32.c
 create mode 100644 compat/fsmonitor/fsm-listen.h
 create mode 100644 fsmonitor--daemon.h
 create mode 100644 fsmonitor-ipc.c
 create mode 100644 fsmonitor-ipc.h
 create mode 100644 fsmonitor-settings.c
 create mode 100644 fsmonitor-settings.h
 create mode 100644 t/helper/test-fsmonitor-client.c
 create mode 100755 t/t7527-builtin-fsmonitor.sh

base-commit: 715d08a9e51251ad8290b181b6ac3b9e1f9719d7
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1041%2Fjeffhostetler%2Fbuiltin-fsmonitor-part2-v9
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1041/jeffhostetler/builtin-fsmonitor-part2-v9
Pull-Request: https://github.com/gitgitgadget/git/pull/1041

Range-diff vs v8:

  1:  e98373f997f =  1:  e98373f997f fsmonitor: enhance existing comments, clarify trivial response handling
  2:  ab68b944173 =  2:  ab68b944173 fsmonitor-ipc: create client routines for git-fsmonitor--daemon
  3:  e04c7301f24 =  3:  e04c7301f24 fsmonitor: config settings are repository-specific
  4:  ea02ba25d8f =  4:  ea02ba25d8f fsmonitor: use IPC to query the builtin FSMonitor daemon
  5:  6ab7db9cb76 =  5:  6ab7db9cb76 fsmonitor: document builtin fsmonitor
  6:  0ce8ae3f2cf =  6:  0ce8ae3f2cf fsmonitor--daemon: add a built-in fsmonitor daemon
  7:  4624ce2fa47 =  7:  4624ce2fa47 fsmonitor--daemon: implement 'stop' and 'status' commands
  8:  a29fe7266a4 =  8:  a29fe7266a4 compat/fsmonitor/fsm-listen-win32: stub in backend for Windows
  9:  2f8a42fdb93 =  9:  2f8a42fdb93 compat/fsmonitor/fsm-listen-darwin: stub in backend for Darwin
 10:  f07800690ee = 10:  f07800690ee fsmonitor--daemon: implement 'run' command
 11:  a6a39a3306d = 11:  a6a39a3306d fsmonitor--daemon: implement 'start' command
 12:  d62e338d008 = 12:  d62e338d008 fsmonitor--daemon: add pathname classification
 13:  53e06b4ae5d = 13:  53e06b4ae5d fsmonitor--daemon: define token-ids
 14:  39f43fabe02 = 14:  39f43fabe02 fsmonitor--daemon: create token-based changed path cache
 15:  239558e34ff = 15:  239558e34ff compat/fsmonitor/fsm-listen-win32: implement FSMonitor backend on Windows
 16:  14b775e9d8b = 16:  14b775e9d8b compat/fsmonitor/fsm-listen-darwin: add MacOS header files for FSEvent
 17:  55bd7aee06c = 17:  55bd7aee06c compat/fsmonitor/fsm-listen-darwin: implement FSEvent listener on MacOS
 18:  c43009124fb = 18:  c43009124fb fsmonitor--daemon: implement handle_client callback
 19:  ed338777b56 = 19:  ed338777b56 help: include fsmonitor--daemon feature flag in version info
 20:  c99bac29d42 = 20:  c99bac29d42 t/helper/fsmonitor-client: create IPC client to talk to FSMonitor Daemon
 21:  c8709da9457 ! 21:  bc94e379b03 t7527: create test for fsmonitor--daemon
     @@ Commit message
          t7527: create test for fsmonitor--daemon
      
          Signed-off-by: Jeff Hostetler <[email protected]>
     -    Signed-off-by: Junio C Hamano <[email protected]>
      
       ## t/t7527-builtin-fsmonitor.sh (new) ##
      @@
     @@ t/t7527-builtin-fsmonitor.sh (new)
      +	rm -rf $1
      +}
      +
     -+is_value () {
     -+	test -n "$1" && test "${1::1}" != "-"
     -+}
     -+
      +start_daemon () {
     -+	r= &&
     -+	tf= &&
     -+	t2= &&
     -+	tk= &&
     ++	r= tf= t2= tk= &&
      +
      +	while test "$#" -ne 0
      +	do
      +		case "$1" in
      +		-C)
     -+			shift;
     -+			is_value $1 || BUG "error: -C requires value"
     -+			r="-C $1"
     ++			r="-C ${2?}"
      +			shift
      +			;;
      +		--tf)
     -+			shift;
     -+			is_value $1 || BUG "error: --tf requires value"
     -+			tf="$1"
     ++			tf="${2?}"
      +			shift
      +			;;
      +		--t2)
     -+			shift;
     -+			is_value $1 || BUG "error: --t2 requires value"
     -+			t2="$1"
     ++			t2="${2?}"
      +			shift
      +			;;
      +		--tk)
     -+			shift;
     -+			is_value $1 || BUG "error: --tk requires value"
     -+			tk="$1"
     ++			tk="${2?}"
      +			shift
      +			;;
     -+		*)
     ++		-*)
      +			BUG "error: unknown option: '$1'"
      +			;;
     ++		*)
     ++			BUG "error: unbound argument: '$1'"
     ++			;;
      +		esac
     ++		shift
      +	done &&
      +
      +	(
 22:  cc39ecf10ae = 22:  06d56d3a733 t/perf: avoid copying builtin fsmonitor files into test repo
 23:  2bb3eb84767 = 23:  2dd02151278 t/helper/test-chmtime: skip directories on Windows
 24:  bab9a9b0802 = 24:  bb88cddc137 t/perf/p7519: fix coding style
 25:  2dd06ad2f71 = 25:  50c2afaa49e t/perf/p7519: speed up test on Windows
 26:  6eaa5765ae1 = 26:  5b18e3b6926 t/perf/p7519: add fsmonitor--daemon test cases
 27:  30957f3930e = 27:  899c23f63c3 fsmonitor--daemon: periodically truncate list of modified files
 28:  c8ca2a17277 = 28:  597a7192f94 fsmonitor--daemon: use a cookie file to sync with file system
 29:  4caf1d89b84 = 29:  68a05fd2892 fsmonitor: force update index after large responses
 30:  f87a1eba693 = 30:  5eb696daba2 t7527: test status with untracked-cache and fsmonitor--daemon
Signature · 1 line
gitgitgadget

Read the cover letter in its thread