Skip to content

tmp-objdir: fix regressions in core.fsyncobjectfiles=batch

Neeraj K. Singh via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fixup! tmp-objdir: new API for creating temporary writable databasesbuiltin/prune.c+1 -00 replies
2/2fixup! tmp-objdir: new API for creating temporary writable databasesenvironment.c tmp-objdir.c tmp-objdir.h+45 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] tmp-objdir: fix regressions in core.fsyncobjectfiles=batch

* Fix prune code to be able to work against multiple cruft directories. I noticed this in self-review.

* When dscho enabled core.fsyncobjectfiles=batch in git-for-windows we saw some test-failures in update-index tests. The root cause is that setup_work_tree does a chdir_notify, which erases the tmp-objdir state. I now unapply and reapply the tmp-objdir around setup_git_env.

This branch autosquashes cleanly and it needs to be merged with ns/batched-fsync, where it currently merges cleanly.

Neeraj Singh (2):
fixup! tmp-objdir: new API for creating temporary writable databases fixup! tmp-objdir: new API for creating temporary writable databases

 builtin/prune.c |  1 +
 environment.c   |  5 +++++
 tmp-objdir.c    | 25 +++++++++++++++++++++++++
 tmp-objdir.h    | 15 +++++++++++++++
 4 files changed, 46 insertions(+)

base-commit: 50741b157f2f90df76a60418e2781b2c1e6e3c78
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1067%2Fneerajsi-msft%2Fns%2Ftmp-objdir-fixes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1067/neerajsi-msft/ns/tmp-objdir-fixes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1067

Signature · 1 line
gitgitgadget