Skip to content

Really retire git-legacy-stash.sh

Johannes Schindelin via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4git-sh-setup: remove remnant bits referring to `git-legacy-stash`git-sh-setup.sh+0 -10 replies
2/4add: remove support for `git-legacy-stash`builtin/add.c+0 -140 replies
3/4Remove documentation for `stash.useBuiltin`Documentation/config/stash.txt+0 -70 replies
4/4stash: stop warning about the obsolete `stash.useBuiltin` config settingbuiltin/stash.c t/t3903-stash.sh+0 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Really retire git-legacy-stash.sh

After proving out git stash for a very long time as a shell script, we eventually converted it to a proper built-in, leaving an escape hatch in place to call the scripted version.

After another very long time, we removed that escape hatch, leaving behind a warning.

Now, almost two years later, let's remove even that warning (and a couple of tidbits that we inadvertently left in the code base).

Johannes Schindelin (4):
git-sh-setup: remove remnant bits referring to git-legacy-stash
add: remove support for git-legacy-stash
Remove documentation for stash.useBuiltin
stash: stop warning about the obsolete stash.useBuiltin config
setting

 Documentation/config/stash.txt |  7 -------
 builtin/add.c                  | 14 --------------
 builtin/stash.c                | 10 ----------
 git-sh-setup.sh                |  1 -
 t/t3903-stash.sh               | 15 ---------------
 5 files changed, 47 deletions(-)

base-commit: 89bece5c8c96f0b962cfc89e63f82d603fd60bed
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1133%2Fdscho%2Freally-retire-legacy-stash-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1133/dscho/really-retire-legacy-stash-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1133

Signature · 1 line
gitgitgadget