Coverity fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 24 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | mingw: avoid accessing uninitialized memory in `is_executable()`run-command.c | +1 | 4 replies | |
| 2/11 | fsmonitor: avoid memory leak in `fsm_settings__get_incompatible_msg()`fsmonitor-settings.c | +6 | 1 reply | |
| 3/11 | submodule--helper: avoid memory leak in `update_submodule()`builtin/ | +2 | 2 replies | |
| 4/11 | get_oid_with_context_1(): avoid use-after-freeobject-name.c | +4 | 1 reply | |
| 5/11 | submodule-config: avoid memory leaksubmodule-config.c | +4 | 2 replies | |
| 6/11 | pack-redundant: avoid using uninitialized memorybuiltin/ | +1 | 1 reply | |
| 7/11 | submodule--helper: avoid memory leak when fetching submodulesbuiltin/ | +1 | 1 reply | |
| 8/11 | read_index_from(): avoid memory leakread-cache.c | +3 | 1 reply | |
| 9/11 | pack-mtimes: avoid closing a bogus file descriptorpack-mtimes.c | +2 | 1 reply | |
| 10/11 | relative_url(): fix incorrect conditionremote.c | +1 | 4 replies | |
| 11/11 | bug_fl(): add missing `va_end()` callusage.c | +1 | 7 replies |
Reviews trailers per patch
None of the 11 patches has a Reviewed-by or Acked-by.
| Patch | Johannes Schindelin |
|---|---|
| 1/11 | |
| 2/11 | |
| 3/11 | |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | Co-authored-by |
| 9/11 | |
| 10/11 | |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/11] Coverity fixes
The release window is a fine time to concentrate on bug fixes, and Coverity can help identify bugs. These are only a couple of fixes, Coverity reported many more, but most of the reports seemed either bogus or harmless (such as resource leaks in test helpers).
Johannes Schindelin (11):
mingw: avoid accessing uninitialized memory in is_executable()
fsmonitor: avoid memory leak in fsm_settings__get_incompatible_msg()
submodule--helper: avoid memory leak in update_submodule() get_oid_with_context_1(): avoid use-after-free
submodule-config: avoid memory leak
pack-redundant: avoid using uninitialized memory
submodule--helper: avoid memory leak when fetching submodules read_index_from(): avoid memory leak
pack-mtimes: avoid closing a bogus file descriptor relative_url(): fix incorrect condition
bug_fl(): add missing va_end() call
builtin/pack-redundant.c | 1 + builtin/submodule--helper.c | 3 +++ fsmonitor-settings.c | 8 ++++++-- object-name.c | 6 ++++-- pack-mtimes.c | 3 ++- read-cache.c | 6 +++--- remote.c | 2 +- run-command.c | 2 +- submodule-config.c | 8 ++++---- usage.c | 1 + 10 files changed, 26 insertions(+), 14 deletions(-)
base-commit: 8168d5e9c23ed44ae3d604f392320d66556453c9
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1264%2Fdscho%2Fcoverity-fixes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1264/dscho/coverity-fixes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1264
Signature · 1 line
gitgitgadget