ci: fix the FreeBSD build

Get series with b4

b4 am [email protected]

Versions newest first

#	Subject and files	Size	Replies	Applied
1/2	t5351: avoid relying on `core.fsyncMethod = batch` to be supported`bulk-checkin.c` `t/t5351-unpack-large-objects.sh`	+10 -2	2 replies
2/2	t5351: avoid using `test_cmp` for binary data`t/t5351-unpack-large-objects.sh`	+1 -1	0 replies

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Cover letter [PATCH 0/2] ci: fix the FreeBSD build

Since 3a251bac0d1a (trace2: only include "fsync" events if we git_fsync(), 2022-07-18), the FreeBSD builds are failing in t5351.6. See
https://cirrus-ci.com/task/4577761405698048 for an example. The run at
https://cirrus-ci.com/task/6004115347079168 shows that this patch fixes the bug.

While verifying the fix on Windows, I noticed a recent, rather terrible performance regression: t5351 all of a sudden takes almost half an hour
[https://github.com/git/git/runs/7398490747?check_suite_focus=true#step:5:171]
to run on Windows. I found a fix, and it now passes in less than half a minute
[https://github.com/gitgitgadget/git/runs/7578071365?check_suite_focus=true#step:5:125]
again.

Johannes Schindelin (2):
t5351: avoid relying on core.fsyncMethod = batch to be supported
t5351: avoid using test_cmp for binary data

 bulk-checkin.c                  |  2 ++
 t/t5351-unpack-large-objects.sh | 12 +++++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

Signature · 1 line

gitgitgadget