Skip to content

tests: fix broken &&-chains & abort loops on error

Eric Sunshine via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3t2407: fix broken &&-chains in compound statementt/t2407-worktree-heads.sh+2 -20 replies
2/3t1092: fix buggy sparse "blame" testt/t1092-sparse-checkout-compatibility.sh+2 -21 reply
3/3t: detect and signal failure within loopt/perf/p7527-builtin-fsmonitor.sh t/t1092-sparse-checkout-compatibility.sh t/t5329-pack-objects-cruft.sh +1 more+9 -95 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] tests: fix broken &&-chains & abort loops on error

This series fixes some broken &&-chains in tests and adds missing || return 1 (or || exit 1) to loops to ensure they exit early upon error. It is a followup to an earlier series which fixed many more such problems.^1
[https://lore.kernel.org/git/[email protected]/]

Eric Sunshine (3):
t2407: fix broken &&-chains in compound statement
t1092: fix buggy sparse "blame" test
t: detect and signal failure within loop

 t/perf/p7527-builtin-fsmonitor.sh        |  2 +-
 t/t1092-sparse-checkout-compatibility.sh | 10 +++++-----
 t/t2407-worktree-heads.sh                |  4 ++--
 t/t5329-pack-objects-cruft.sh            |  8 ++++----
 t/t6429-merge-sequence-rename-caching.sh |  2 +-
 5 files changed, 13 insertions(+), 13 deletions(-)

base-commit: 795ea8776befc95ea2becd8020c7a284677b4161
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1312%2Fsunshineco%2Fchainmore-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1312/sunshineco/chainmore-v1
Pull-Request: https://github.com/git/git/pull/1312

Signature · 1 line
gitgitgadget