Correct credential helper discrepancies handling input
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | wincred: ignore unknown lines (do not die)contrib/ | +5 | 2 replies | |
| 2/3 | netrc: ignore unknown lines (do not die)contrib/ | +4 | 0 replies | |
| 3/3 | osxkeychain: clarify that we ignore unknown linescontrib/ | +5 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] Correct credential helper discrepancies handling input
Whilst working in the credential helper and auth space I happened to notice that the behaviour of some of the credential helpers in contrib/credential/ is not consistent.
Specifically both the git-credential-wincred and git-credential-netrc helpers die when they receive unknown credential property keys, which is contrary to the behaviour of all the other in-tree helpers including:
git-credential-cache, -store, -libsecret, -gnome-keyring, -osxkeychain.
Also update the git-credential-osxkeychain helper to include a comment making it's behaviour explicit in ignoring unknown keys, as per other helpers.
Matthew John Cheetham (3):
wincred: ignore unknown lines (do not die)
netrc: ignore unknown lines (do not die)
osxkeychain: clarify that we ignore unknown lines
contrib/credential/netrc/git-credential-netrc.perl | 5 ++++- .../credential/osxkeychain/git-credential-osxkeychain.c | 5 +++++ contrib/credential/wincred/git-credential-wincred.c | 7 +++++-- 3 files changed, 14 insertions(+), 3 deletions(-)
base-commit: dd3f6c4cae7e3b15ce984dce8593ff7569650e24
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1363%2Fmjcheetham%2Fcredhelper-fixes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1363/mjcheetham/credhelper-fixes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1363
Signature · 1 line
gitgitgadget