Skip to content

RFC tests: add test_todo() for known failures

Phillip Wood via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tests: add test_todo() to mark known breakagest/README t/t0000-basic.sh t/t3401-rebase-and-am-rename.sh +3 more+194 -558 replies
2/3test_todo: allow [!] grep as the commandt/t0000-basic.sh t/t3510-cherry-pick-sequence.sh t/t4014-format-patch.sh +1 more+82 -263 replies
3/3test_todo: allow [verbose] test as the commandt/t0000-basic.sh t/t0050-filesystem.sh t/t3903-stash.sh +1 more+36 -171 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] [RFC] tests: add test_todo() for known failures

test_todo() is intended as a fine grained alternative to test_expect_failure(). Rather than marking the whole test as failing test_todo() is used to mark individual failing commands within a test. This approach to writing failing tests allows us to detect unexpected failures that are hidden by test_expect_failure().

This series attempts to keep most of the benefits test_expect_todo() previously proposed by Ævar[1] while being simpler to use.

[1]
https://lore.kernel.org/git/[email protected]/

Phillip Wood (3):
[RFC] tests: add test_todo() to mark known breakages [RFC] test_todo: allow [!] grep as the command [RFC] test_todo: allow [verbose] test as the command

 t/README                        |  12 ++
 t/t0000-basic.sh                |  92 +++++++++++++++
 t/t0050-filesystem.sh           |   4 +-
 t/t3401-rebase-and-am-rename.sh |  12 +-
 t/t3424-rebase-empty.sh         |   6 +-
 t/t3510-cherry-pick-sequence.sh |  12 +-
 t/t3600-rm.sh                   |   8 +-
 t/t3903-stash.sh                |  12 +-
 t/t4014-format-patch.sh         |  20 ++--
 t/test-lib-functions.sh         | 194 +++++++++++++++++++++++++-------
 10 files changed, 293 insertions(+), 79 deletions(-)

base-commit: bcd6bc478adc4951d57ec597c44b12ee74bc88fb
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1374%2Fphillipwood%2Ftest-todo-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1374/phillipwood/test-todo-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1374

Signature · 1 line
gitgitgadget