Skip to content

jt/fetch-cdn-offload: fix build with clang

Johannes Schindelin via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1fixup! upload-pack: refactor reading of pack-objects outupload-pack.c+1 -13 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] jt/fetch-cdn-offload: fix build with clang

I think this is actually legitimate a build error (see e.g.
https://dev.azure.com/gitgitgadget/git/_build/results?buildId=2394), and I am quite surprised that GCC accepts this.

Note: after thinking about this for a while, I guess an empty string would work, too (i.e. "" instead of " 0"), but I already waited for the macOS build to finish at https://github.com/gitgitgadget/git/pull/139, and it's a fixup! for Jonathan to pick up, anyway...

Junio, could I ask you to apply this on top of your SQUASH??? to fix the build?

Johannes Schindelin (1):
fixup! upload-pack: refactor reading of pack-objects out

 upload-pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

base-commit: 2c31d711669adc7a7bfad06df37b976af99dfaa6
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-139%2Fdscho%2Fjt%2Ffetch-cdn-offload-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-139/dscho/jt/fetch-cdn-offload-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/139

Signature · 1 line
gitgitgadget