Skip to content

t3600: use test_path_is_dir and test_path_is_file

Rohit Ashiwal via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest1 patch 4 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1t3600: use test_path_is_dir and test_path_is_filet/t3600-rm.sh+48 -484 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/1] [GSoC][PATCH] t3600: use test_path_is_dir and test_path_is_file

Previously we were using test -(d|f) to verify the presencee of a directory/file, but we already have helper functions, viz, test_path_is_dir and test_path_is_file with same functionality. This patch will replace test -(d|f) calls in t3600-rm.sh.

Rohit Ashiwal (1):
t3600: use test_path_is_dir and test_path_is_file

 t/t3600-rm.sh | 96 +++++++++++++++++++++++++--------------------------
 1 file changed, 48 insertions(+), 48 deletions(-)

base-commit: 8104ec994ea3849a968b4667d072fedd1e688642
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-152%2Fr1walz%2Frefactor-tests-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-152/r1walz/refactor-tests-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/152

Range-diff vs v1:

1: bf5eb04579 ! 1: fcafc87b38 tests: replace test -(d|f) with test_path_is_(dir|file)
@@ -1,12 +1,16 @@
Author: Rohit Ashiwal <[email protected]>

- tests: replace test -(d|f) with test_path_is_(dir|file)
+ t3600: use test_path_is_dir and test_path_is_file

- t3600-rm.sh: Previously we were using test -(d|f)
- to verify the presencee of a directory/file, but we
- already have helper functions, viz, test_path_is_dir
- and test_path_is_file with same functionality. This
- patch will replace test -(d|f) calls in t3600-rm.sh.
+ Previously we were using test -(d|f) to verify
+ the presence of a directory/file, but we already
+ have helper functions, viz, test_path_is_dir
+ and test_path_is_file with better functionality.
+ This patch will replace test -(d|f) calls in t3660.sh
+
+ These helper functions make code more readable
+ and informative to someone new to code, also
+ these functions have better error messages

Signature · 1 line
gitgitgadget