Redact unsafe URLs in the Trace2 output
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | trace2: fix signature of trace2_def_param() macrotrace2.h | +2 | 1 reply | |
| 2/4 | trace2: redact passwords from https:// URLs by defaultt/ trace2.c | +136 | 2 replies | |
| 3/4 | t0211: test URL redacting in PERF formatt/ | +20 | 0 replies | |
| 4/4 | t0212: test URL redacting in EVENT formatt/ t/ | +95 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by.
| Patch | Jeff Hostetler |
|---|---|
| 1/4 | |
| 2/4 | Co-authored-by |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] Redact unsafe URLs in the Trace2 output
The Trace2 output can contain secrets when a user issues a Git command with sensitive information in the command-line. A typical (if highly discouraged) example is: git clone https://user:[email protected]/.
With this PR, the Trace2 output redacts passwords in such URLs by default.
This series also includes a commit to temporarily disable leak checking on t0210,t0211 because the tests uncover other unrelated bugs in Git.
These patches were integrated into Microsoft's fork of Git, as
https://github.com/microsoft/git/pull/616, and have been cooking there ever since.
Jeff Hostetler (3):
trace2: fix signature of trace2_def_param() macro
t0211: test URL redacting in PERF format
t0212: test URL redacting in EVENT format
Johannes Schindelin (1):
trace2: redact passwords from https:// URLs by default
t/helper/test-trace2.c | 55 ++++++++++++++++++ t/t0210-trace2-normal.sh | 20 ++++++- t/t0211-trace2-perf.sh | 21 ++++++- t/t0212-trace2-event.sh | 40 +++++++++++++ trace2.c | 120 ++++++++++++++++++++++++++++++++++++++- trace2.h | 4 +- 6 files changed, 253 insertions(+), 7 deletions(-)
base-commit: 564d0252ca632e0264ed670534a51d18a689ef5d
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1616%2Fdscho%2Ftrace2-redact-credentials-in-https-urls-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1616/dscho/trace2-redact-credentials-in-https-urls-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1616
Signature · 1 line
gitgitgadget