Skip to content

fsmonitor: completing a stale patch that Implements fsmonitor for Linux

marzi via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7fsmonitor: rebase with mastercompat/fsmonitor/fsm-health-linux.c compat/fsmonitor/fsm-ipc-darwin.c compat/fsmonitor/fsm-ipc-linux.c +4 more+142 -1191 reply
2/7fsmonitor: determine if filesystem is local or remoteMakefile compat/fsmonitor/fsm-path-utils-linux.c compat/fsmonitor/fsm-path-utils-linux.h +1 more+301 -02 replies
3/7fsmonitor: implement filesystem change listener for Linuxcompat/fsmonitor/fsm-listen-linux.c+676 -01 reply
4/7fsmonitor: enable fsmonitor for Linuxcontrib/buildsystems/CMakeLists.txt+10 -10 replies
5/7fsmonitor: test updatest/t7527-builtin-fsmonitor.sh+106 -320 replies
6/7fsmonitor: update doc for LinuxDocumentation/config/fsmonitor--daemon.txt Documentation/git-fsmonitor--daemon.txt+19 -110 replies
7/7fsmonitor: addressed comments for patch 1352compat/fsmonitor/fsm-health-linux.c compat/fsmonitor/fsm-ipc-unix.c compat/fsmonitor/fsm-listen-linux.c +2 more+95 -871 reply

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchEric DeCoste
1/7Patch-originally-by
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] fsmonitor: completing a stale patch that Implements fsmonitor for Linux

The goal in the original pull is to deliver fsmonitor for Linux that works similar to fsmonitor for Windows and Mac OS.

The original stale patch : https://github.com/git/git/pull/1352

This patch set builds upon previous work for done for Windows and Mac OS to implement a fsmonitor back-end for Linux based on the Linux inotify API. inotify differs significantly from the equivalent Windows and Mac OS APIs in that a watch must be registered for every directory of interest (rather than a singular watch at the root of the directory tree) and special care must be taken to handle directory renames correctly.

More information about inotify:
https://man7.org/linux/man-pages/man7/inotify.7.html

Eric DeCosta (6):
fsmonitor: rebase with master
fsmonitor: determine if filesystem is local or remote
fsmonitor: implement filesystem change listener for Linux
fsmonitor: enable fsmonitor for Linux
fsmonitor: test updates
fsmonitor: update doc for Linux

marzi.esipreh (1):
fsmonitor: addressed comments for patch 1352

 Documentation/config/fsmonitor--daemon.txt |   4 +-
 Documentation/git-fsmonitor--daemon.txt    |  26 +-
 Makefile                                   |   4 +
 compat/fsmonitor/fsm-health-linux.c        |  24 +
 compat/fsmonitor/fsm-ipc-darwin.c          |  57 +-
 compat/fsmonitor/fsm-ipc-linux.c           |   1 +
 compat/fsmonitor/fsm-ipc-unix.c            |  55 ++
 compat/fsmonitor/fsm-listen-linux.c        | 678 +++++++++++++++++++++
 compat/fsmonitor/fsm-path-utils-linux.c    | 196 ++++++
 compat/fsmonitor/fsm-path-utils-linux.h    |  91 +++
 compat/fsmonitor/fsm-settings-darwin.c     |  64 +-
 compat/fsmonitor/fsm-settings-linux.c      |   1 +
 compat/fsmonitor/fsm-settings-unix.c       |  64 ++
 config.mak.uname                           |  11 +
 contrib/buildsystems/CMakeLists.txt        |  11 +-
 t/t7527-builtin-fsmonitor.sh               | 138 ++++-
 16 files changed, 1262 insertions(+), 163 deletions(-)
 create mode 100644 compat/fsmonitor/fsm-health-linux.c
 create mode 100644 compat/fsmonitor/fsm-ipc-linux.c
 create mode 100644 compat/fsmonitor/fsm-ipc-unix.c
 create mode 100644 compat/fsmonitor/fsm-listen-linux.c
 create mode 100644 compat/fsmonitor/fsm-path-utils-linux.c
 create mode 100644 compat/fsmonitor/fsm-path-utils-linux.h
 create mode 100644 compat/fsmonitor/fsm-settings-linux.c
 create mode 100644 compat/fsmonitor/fsm-settings-unix.c

base-commit: 4fc51f00ef18d2c0174ab2fd39d0ee473fd144bd
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1667%2Fmaryis%2Ffsmonitor_linux-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1667/maryis/fsmonitor_linux-v1
Pull-Request: https://github.com/git/git/pull/1667

Signature · 1 line
gitgitgadget