utf8: change return type of some helpers from int to size_t
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | utf8: change type from int to size_tbuiltin/ builtin/ builtin/ +8 more | +21 | 1 reply | |
| 2/2 | utf8: make utf8_strnwidth & utf8_strwidth return size_t instead of intutf8.c utf8.h | +5 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] utf8: change return type of some helpers from int to size_t
Hello,
There are lot of places in the codebase where int is used to store size of an object instead of size_t (which is better alternative due to reasons like portability, readability, etc). This patch series accomplishes one such #TODO comment, which addresses this issue.
I appreciate your review and feedback on this patch series.
Best regards, Mohit Marathe
Mohit Marathe (2):
utf8: change type from int to size_t
utf8: make utf8_strnwidth & utf8_strwidth return size_t instead of int
builtin/blame.c | 6 +++--- builtin/branch.c | 2 +- builtin/fetch.c | 2 +- builtin/worktree.c | 4 ++-- column.c | 2 +- diff.c | 8 +++++--- gettext.c | 2 +- gettext.h | 2 +- pretty.c | 4 ++-- utf8.c | 14 +++++--------- utf8.h | 4 ++-- wt-status.c | 4 ++-- 12 files changed, 26 insertions(+), 28 deletions(-)
base-commit: 2953d95d402b6bff1a59c4712f4d46f1b9ea137f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1690%2Fmohit-marathe%2Fint-to-size_t-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1690/mohit-marathe/int-to-size_t-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1690
Signature · 1 line
gitgitgadget