Unify trailer formatting functions
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | format_trailer_info(): use trailer_item objectst/ t/ trailer.c | +30 | 0 replies | |
| 2/5 | format_trailer_info(): drop redundant unfold_value()trailer.c | +0 | 0 replies | |
| 3/5 | format_trailer_info(): append newline for non-trailer linest/ t/ trailer.c | +11 | 1 reply | |
| 4/5 | trailer: begin formatting unificationbuiltin/ trailer.c trailer.h | +19 | 0 replies | |
| 5/5 | trailer: finish formatting unificationbuiltin/ trailer.c trailer.h | +9 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by.
| Patch | Junio C Hamano | Christian Couder |
|---|---|---|
| 1/5 | ||
| 2/5 | ||
| 3/5 | ||
| 4/5 | Helped-by | Helped-by |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] Unify trailer formatting functions
This series is based on the initial series [1], notably the v4 version of patches 10-16 as suggested by Christian [2]. This version addresses the review comments for those patches, namely the avoidance of (temporary) test breakages.
The central idea is to unify the functions format_trailer_info() and format_trailers() together (preferring the name of the latter), so that both the interpret-trailers built-in and format_trailers_from_commit() can call the same format_trailers() function, while maintaining feature parity.
[1]
https://lore.kernel.org/git/[email protected]/
[2]
https://lore.kernel.org/git/CAP8UFD08F0V13X0+CJ1uhMPzPWVMs2okGVMJch0DkQg5M3BWLA@mail.gmail.com/
Linus Arver (5):
format_trailer_info(): use trailer_item objects format_trailer_info(): drop redundant unfold_value() format_trailer_info(): append newline for non-trailer lines
trailer: begin formatting unification
trailer: finish formatting unification
trailer.c | 81 ++++++++++++++++++++----------------------------------- trailer.h | 13 +++------ 2 files changed, 32 insertions(+), 62 deletions(-)
base-commit: 4f9b731bdeccffa1b13e5edf4bc0428b8d49704e
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1694%2Flistx%2Ftrailer-api-part-2-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1694/listx/trailer-api-part-2-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1694
Signature · 1 line
gitgitgadget