Skip to content

git-compat-util: move convert_slashes from compat/mingw.h and rename it

Mohit Marathe via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2git-compat-util: migrate `convert_slashes()` from compat/mingw.habspath.c compat/mingw.c compat/mingw.h +2 more+12 -111 reply
2/2test-lib: replace repeated code logic with an existing helpert/unit-tests/test-lib.c+3 -62 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] git-compat-util: move convert_slashes from compat/mingw.h and rename it

Hi all,

This series aims to complete a #leftoverbits: https://lore.kernel.org/
git/[email protected]/ by moving convert_slashes() to git-compat-util.h and renaming it to change_path_separators().

I appreciate your review and feedback on this patch series.

Best regards, Mohit Marathe

Mohit Marathe (2):
git-compat-util: migrate convert_slashes() from compat/mingw.h
test-lib: replace repeated code logic with an existing helper

 abspath.c               | 4 ++--
 compat/mingw.c          | 4 ++--
 compat/mingw.h          | 6 ------
 git-compat-util.h       | 7 +++++++
 path.c                  | 2 +-
 t/unit-tests/test-lib.c | 9 +++------
 6 files changed, 15 insertions(+), 17 deletions(-)

base-commit: 2953d95d402b6bff1a59c4712f4d46f1b9ea137f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1699%2Fmohit-marathe%2Fconvert-slashes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1699/mohit-marathe/convert-slashes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1699

Signature · 1 line
gitgitgadget