remote: branch setting fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 17 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | remote: fix set-branches when no branches are setbuiltin/ t/ | +17 | 2 replies | |
| 2/4 | remote: print an error if refspec cannot be removedbuiltin/ | +1 | 6 replies | |
| 3/4 | remote add: use strvec to store tracking branchesbuiltin/ | +6 | 2 replies | |
| 4/4 | remote: check branch namesbuiltin/ t/ | +47 | 7 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] remote: branch setting fixes
This series fixes some rough edges when setting remote tracking branches with "git remote set-branches" or "git remote add -t". Han Jiang reported that if there is no fetch refspec set for a remote then "git remote set-branches" silently fails. While investigating that I noticed that the code does not check that the branch names are syntactically valid refnames and so can create invalid refspecs. This series fixes both issues.
Phillip Wood (4):
remote: fix set-branches when no branches are set
remote: print an error if refspec cannot be removed remote add: use strvec to store tracking branches
remote: check branch names
builtin/remote.c | 41 ++++++++++++++++++++++++++++++++--------- t/t5505-remote.sh | 42 +++++++++++++++++++++++++++++++++++++++--- 2 files changed, 71 insertions(+), 12 deletions(-)
base-commit: 4590f2e9412378c61eac95966709c78766d326ba
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1789%2Fphillipwood%2Fremote-set-branches-missing-fetch-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1789/phillipwood/remote-set-branches-missing-fetch-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1789
Signature · 1 line
gitgitgadget