Skip to content

Some defensive programming

Johannes Schindelin via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14revision: defensive programmingrevision.c+3 -01 reply
2/14get_parent(): defensive programmingobject-name.c+1 -12 replies
3/14fetch-pack: defensive programmingfetch-pack.c+1 -11 reply
4/14unparse_commit(): defensive programmingcommit.c+1 -10 replies
5/14verify_commit_graph(): defensive programmingcommit-graph.c+5 -00 replies
6/14stash: defensive programmingbuiltin/stash.c+1 -10 replies
7/14stash: defensive programmingbuiltin/stash.c+5 -00 replies
8/14push: defensive programmingbuiltin/push.c+1 -10 replies
9/14fetch: defensive programmingbuiltin/fetch.c+2 -10 replies
10/14describe: defensive programmingbuiltin/describe.c+2 -00 replies
11/14inherit_tracking(): defensive programmingbranch.c+2 -00 replies
12/14submodule: check return value of `submodule_from_path()`builtin/submodule--helper.c+3 -00 replies
13/14test-tool repository: check return value of `lookup_commit()`t/helper/test-repository.c+2 -00 replies
14/14shallow: handle missing shallow commits gracefullyshallow.c+2 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] Some defensive programming

These patches implement some defensive programming to address complaints some static analyzers might have.

Johannes Schindelin (14):
revision: defensive programming
get_parent(): defensive programming
fetch-pack: defensive programming
unparse_commit(): defensive programming verify_commit_graph(): defensive programming
stash: defensive programming
stash: defensive programming
push: defensive programming
fetch: defensive programming
describe: defensive programming
inherit_tracking(): defensive programming
submodule: check return value of submodule_from_path() test-tool repository: check return value of lookup_commit()
shallow: handle missing shallow commits gracefully

 branch.c                    | 2 ++
 builtin/describe.c          | 2 ++
 builtin/fetch.c             | 3 ++-
 builtin/push.c              | 2 +-
 builtin/stash.c             | 7 ++++++-
 builtin/submodule--helper.c | 3 +++
 commit-graph.c              | 5 +++++
 commit.c                    | 2 +-
 fetch-pack.c                | 2 +-
 object-name.c               | 2 +-
 revision.c                  | 3 +++
 shallow.c                   | 3 ++-
 t/helper/test-repository.c  | 2 ++
 13 files changed, 31 insertions(+), 7 deletions(-)

base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1890%2Fdscho%2Fdefensive-programming-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1890/dscho/defensive-programming-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1890

Signature · 1 line
gitgitgadget