CodeQL-inspired fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 24 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | commit: simplify codebuiltin/ | +1 | 3 replies | |
| 2/11 | fetch: carefully clear local variable's address after usebuiltin/ | +1 | 1 reply | |
| 3/11 | commit-graph: avoid malloc'ing a local variablecommit-graph.c | +69 | 2 replies | |
| 4/11 | upload-pack: rename `enum` to reflect the operationupload-pack.c | +17 | 1 reply | |
| 5/11 | has_dir_name(): make code more obviousread-cache.c | +13 | 1 reply | |
| 6/11 | fetch: avoid unnecessary work when there is no current branchbuiltin/ | +1 | 1 reply | |
| 7/11 | Avoid redundant conditionshelp.c transport-helper.c | +2 | 1 reply | |
| 8/11 | trace2: avoid "futile conditional"trace2/ | +5 | 1 reply | |
| 9/11 | commit-graph: avoid using stale stack addressescommit-graph.c | +9 | 1 reply | |
| 10/11 | bundle-uri: avoid using undefined output of `sscanf()`bundle-uri.c | +7 | 7 replies | |
| 11/11 | sequencer: stop pretending that an assignment is a conditionsequencer.c | +6 | 3 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/11] CodeQL-inspired fixes
CodeQL [https://codeql.github.com/] pointed out a couple of issues, which are addressed in this patch series.
Johannes Schindelin (11):
commit: simplify code
fetch: carefully clear local variable's address after use
commit-graph: avoid malloc'ing a local variable
upload-pack: rename enum to reflect the operation has_dir_name(): make code more obvious
fetch: avoid unnecessary work when there is no current branch Avoid redundant conditions
trace2: avoid "futile conditional"
commit-graph: avoid using stale stack addresses
bundle-uri: avoid using undefined output of sscanf()
sequencer: stop pretending that an assignment is a condition
builtin/commit.c | 2 +- builtin/fetch.c | 3 +- bundle-uri.c | 12 ++-- commit-graph.c | 148 +++++++++++++++++++++++---------------------- help.c | 2 +- read-cache.c | 55 ++++------------- sequencer.c | 9 ++- trace2/tr2_tmr.c | 24 ++------ transport-helper.c | 2 +- upload-pack.c | 34 +++++------ 10 files changed, 130 insertions(+), 161 deletions(-)
base-commit: 38af977b81bbf8ce8c0004d3f4046a823ecb30a1
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1891%2Fdscho%2Fcodeql-fixes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1891/dscho/codeql-fixes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1891
Signature · 1 line
gitgitgadget