Skip to content

pkt-line: fix incorrect function declaration

Johannes Schindelin via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2pkt-line: fix declaration of `set_packet_header()`pkt-line.h+1 -111 replies
2/2parse-options: adjust `parse_opt_unknown_cb()`s declared return typeparse-options.h+3 -11 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchJohannes SchindelinJeff King
1/2Noticed-by Helped-by
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] pkt-line: fix incorrect function declaration

MS Visual C detected a mismatch between the declaration and the definition of set_packet_header(): it is declared with its second parameter missing the const attribute.

It also detected a mismatch between the declaration and the definition of parse_opt_unknown_cb().

These problems must have been introduced very recently; I do not recall seeing them before today in any of Git for Windows' ever-green branches (i.e. master semi-automatically rebased continously onto pu, next, master and maint).

You could not have seen it in git.git's own Azure Pipeline, as Git for Windows' version already has support to build with MSVC (I plan to submit this directly after v2.22.0 is out).

Johannes Schindelin (2):
pkt-line: fix declaration of set_packet_header()
parse-options: adjust parse_opt_unknown_cb()s declared return type

 parse-options.h | 4 +++-
 pkt-line.h      | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

base-commit: ab15ad1a3b4b04a29415aef8c9afa2f64fc194a2
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-192%2Fdscho%2Ffix-set_packet_header-signature-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-192/dscho/fix-set_packet_header-signature-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/192

Signature · 1 line
gitgitgadget