Skip to content

Make t2024 NO_PERL-safe

Johannes Schindelin via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest1 patch 2 repliesIn review

Changes in v2 from the cover letter

https://github.com/gitgitgadget/gitgitgadget/issues/29):

* reworded the commit message slightly.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1t2024: mark a `checkout -p` test as requiring Perlt/t2024-checkout-dwim.sh+2 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/1] Make t2024 NO_PERL-safe

While trying to run the build & test with NO_PERL, I noticed that t2024 had a failing test case. This patch works around that failing test case by skipping it when we know that the error message looks different than that test case would expect.

Changes since v1 (which did not make it to the list due to
https://github.com/gitgitgadget/gitgitgadget/issues/29):

* reworded the commit message slightly.

Johannes Schindelin (1):
t2024: mark a checkout -p test as requiring Perl

 t/t2024-checkout-dwim.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

base-commit: 8d7b558baebe3abbbad4973ce1e1f87a7da17f47
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-20%2Fdscho%2Fcheckout-default-remote-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-20/dscho/checkout-default-remote-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/20

Range-diff vs v1:

1: 619d7bcc31 ! 1: 8d46b31f5a t2024: mark a checkout -p test as requiring Perl
@@ -3,9 +3,11 @@
t2024: mark a checkout -p test as requiring Perl

A recently-added test case tries to verify that the output of `checkout
- -p` contains a certain piece of advice. But if Git was built without
- Perl and therefore lacks support for git add -i, the error output
- contains the hint that -p is not even available instead.
+ -p` contains a certain piece of advice.
+
+ But if Git was built without Perl and therefore lacks support for `git
+ add -i, the error output contains the hint that -p` is not even
+ available instead.

Let's just skip that test case altogether if Git was built with NO_PERL.

Signature · 1 line
gitgitgadget