Skip to content

repo: remove redundant variable shadow in stats_table_print_structure

Mansi Singh via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2t7605: use test_path_is_file instead of test -ft/t7605-merge-resolve.sh+3 -30 replies
2/2repo: remove redundant variable shadow in stats_table_print_structurebuiltin/repo.c+0 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] repo: remove redundant variable shadow in stats_table_print_structure

The variable i is declared in the outer scope of stats_table_print_structure() and then re-declared inside the loop, shadowing the outer one unnecessarily. Remove the redundant inner declaration to clean up the scope.

Signed-off-by Mansi Singh [email protected]

Mansi (1):
t7605: use test_path_is_file instead of test -f

Mansi Singh (1):
repo: remove redundant variable shadow in stats_table_print_structure

 builtin/repo.c           | 1 -
 t/t7605-merge-resolve.sh | 6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)

base-commit: 7c02d39fc2ed2702223c7674f73150d9a7e61ba4
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2062%2FMansiSingh17%2Frepo-fix-variable-shadow-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2062/MansiSingh17/repo-fix-variable-shadow-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2062

Signature · 1 line
gitgitgadget

Read the cover letter in its thread