Skip to content

Backfill fixes and edges

Elijah Newren via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3backfill: reject rev-list arguments that do not make sensebuiltin/backfill.c+23 -01 reply
2/3backfill: document acceptance of revision-range in more standard mannerDocumentation/git-backfill.adoc builtin/backfill.c+13 -41 reply
3/3backfill: default to grabbing edge blobs tooDocumentation/git-backfill.adoc builtin/backfill.c t/t5620-backfill.sh+119 -81 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Backfill fixes and edges

This topic fixes a few minor issues in git backfill (from ds/backfill-revs this cycle), although some might see the third patch as more feature than fix, and the first two patches are pretty minor and probably do not merit consideration before the release this late in the cycle.

Overview:

* Patch 1: As a wise man once said, "Sending arbitrary command-line arguments to setup_revisions() creates an opportunity for behavior you are not expecting. For instance, can users...supply --first-parent? What happens if they add an --author filter?" ;-) I think these particular cases might work, but other rev-list options don't make sense, so let's error on ones that don't.
* Patch 2: Making documentation more consistent with other commands
* Patch 3: Tweak the ranges so we actually prevent on-demand blob downloading better with a new --[no-]include-edges flag.

Elijah Newren (3):
backfill: reject rev-list arguments that do not make sense
backfill: document acceptance of revision-range in more standard
manner
backfill: default to grabbing edge blobs too

 Documentation/git-backfill.adoc |  22 ++++++-
 builtin/backfill.c              |  31 ++++++++-
 t/t5620-backfill.sh             | 110 ++++++++++++++++++++++++++++++--
 3 files changed, 153 insertions(+), 10 deletions(-)

base-commit: 9f223ef1c026d91c7ac68cc0211bde255dda6199
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2088%2Fnewren%2Fbackfill-fixes-and-edges-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2088/newren/backfill-fixes-and-edges-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2088

Signature · 1 line
gitgitgadget