Skip to content

Fix issues pointed out in Git for Windows by Coverity after merging v2.56.0-rc0

Johannes Schindelin via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7wrapper: guard writev_in_full() against signed overflowwrapper.c+4 -00 replies
2/7gpg-interface: make signature-prefix matching length-awaregpg-interface.c+5 -53 replies
3/7midx: validate incremental MIDX pack IDsmidx.c+9 -30 replies
4/7rerere: do not record failed conflict resolution datarerere.c+26 -41 reply
5/7t/unit-tests: check reftable iterator initializationt/unit-tests/u-reftable-table.c+1 -10 replies
6/7oss-fuzz: handle reftable iterator initialization failuresoss-fuzz/fuzz-reftable.c+10 -80 replies
7/7test-read-midx: check midx_fill_entry() resultt/helper/test-read-midx.c+5 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] Fix issues pointed out in Git for Windows by Coverity after merging v2.56.0-rc0

These Coverity reports are new as of this -rc cycle; Apart from the writev one, I don't think any of these are pressing, in most cases I am still puzzled why they were reported only now.

Johannes Schindelin (7):
wrapper: guard writev_in_full() against signed overflow
gpg-interface: make signature-prefix matching length-aware
midx: validate incremental MIDX pack IDs
rerere: do not record failed conflict resolution data t/unit-tests: check reftable iterator initialization
oss-fuzz: handle reftable iterator initialization failures
test-read-midx: check midx_fill_entry() result

 gpg-interface.c                 | 10 +++++-----
 midx.c                          | 12 +++++++++---
 oss-fuzz/fuzz-reftable.c        | 18 ++++++++++--------
 rerere.c                        | 30 ++++++++++++++++++++++++++----
 t/helper/test-read-midx.c       |  6 +++++-
 t/unit-tests/u-reftable-table.c |  2 +-
 wrapper.c                       |  4 ++++
 7 files changed, 60 insertions(+), 22 deletions(-)

base-commit: 12cb6293d6288865c1a133cf22accbaf99d13eb6
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2231%2Fdscho%2Ffix-coverity-high-severity-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2231/dscho/fix-coverity-high-severity-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2231

Signature · 1 line
gitgitgadget