Skip to content

Fix two hook configuration bugs

Thomas Bachem via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hook: honor hook.<event>.enabled for the hookdir hookbuiltin/hook.c hook.c hook.h +1 more+47 -104 replies
2/2hook: accept .enabled and .parallel given without a valuehook.c t/t1800-hook.sh+24 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Fix two hook configuration bugs

Two small fixes for hook configuration. With the first, hook.pre-commit.enabled=false also stops the pre-commit hook in the hooks directory, as the documentation says. With the second, hook.*.enabled and hook.*.parallel can be given without a value, which means true, as for any other boolean.

Thomas Bachem (2):
hook: honor hook.<event>.enabled for the hookdir hook
hook: accept .enabled and .parallel given without a value

 builtin/hook.c  |  6 ++++--
 hook.c          | 17 +++++++++++------
 hook.h          |  8 +++++++-
 t/t1800-hook.sh | 51 +++++++++++++++++++++++++++++++++++++++++++++++--
 4 files changed, 71 insertions(+), 11 deletions(-)

base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2272%2Fthomasbachem%2Fhook-event-enabled-hookdir-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2272/thomasbachem/hook-event-enabled-hookdir-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2272

Signature · 1 line
gitgitgadget