t5608: assert that the packs involved really are that large
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | unpack-objects: pass the size of a streamed blob as size_tbuiltin/ | +1 | 0 replies | |
| 2/2 | t5608: assert that the packs involved really are that larget/ | +41 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] t5608: assert that the packs involved really are that large
I was looking at which tests take the most time in CI, and t5608 stood out when (unscientifically) spot-checking a single run. Profiling its setup showed that it does not actually create the >2GB pack that the test's name promises. While adding assertions for that, it turned out that the unpack-objects variant of the >4GB test never runs unpack-objects either.
Once it does, it fails on Windows, because unpack-objects narrows the size of a streamed blob to "unsigned long" on its way to the object writer. The first patch fixes that.
Kristofer Karlsson (2):
unpack-objects: pass the size of a streamed blob as size_t
t5608: assert that the packs involved really are that large
builtin/unpack-objects.c | 2 +- t/t5608-clone-2gb.sh | 54 ++++++++++++++++++++++++++++++---------- 2 files changed, 42 insertions(+), 14 deletions(-)
base-commit: 0ffa3e35c7c82ab8d0de226149fb03b3f7674d05
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2299%2Fspkrka%2Ft5608-real-2gb-pack-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2299/spkrka/t5608-real-2gb-pack-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2299
Signature · 1 line
gitgitgadget