Skip to content

submodule foreach: fix recursion of options

Morian Sonnet via GitGitGadget git 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 patch 5 repliesIn review
  2. v11 patch 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1submodule foreach: fix recursion of optionsbuiltin/submodule--helper.c t/t7407-submodule-foreach.sh+8 -014 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/1] submodule foreach: fix recursion of options

During the usage of git in Buildkite we noted that git fails upon calling git submodule foreach --recursive git reset --hardafter updating git version to 2.22.0.

This is due to a problem with the recursive calling of git submodule--helper itself, which is fixed in the patch below.

Morian Sonnet (1):
submodule foreach: fix recursion of options

 builtin/submodule--helper.c  | 1 +
 t/t7407-submodule-foreach.sh | 7 +++++++
 2 files changed, 8 insertions(+)

base-commit: b697d92f56511e804b8ba20ccbe7bdc85dc66810
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-263%2Fmomoson%2Fmaster-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-263/momoson/master-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/263

Range-diff vs v1:

1: e766e51777 ! 1: c46e5bd140 submodule foreach: fix recursion of options

     @@ -65,8 +65,10 @@
       '
       
      +test_expect_success 'option-like arguments passed to foreach recurse correctly' '
     -+  cd super &&
     -+  git submodule foreach --recursive git reset --hard
     ++  (
     ++    cd super &&
     ++    git submodule foreach --recursive git reset --hard
     ++  )
      +'
      +
       test_done
Signature · 1 line
gitgitgadget

Read the cover letter in its thread