fetch: add trace2 instrumentation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest1 patch 1 replyIn review
- v41 patch 0 repliesSuperseded
- v31 patch 9 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 2 patches | 0 replies | Superseded | |
| v1 | 1 patch | 1 reply | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | fetch: add trace2 instrumentationfetch-pack.c | +12 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH v5 0/1] fetch: add trace2 instrumentation
Add trace2 regions to fetch-pack.c to better track time spent in the various phases of a fetch:
* matching common remote and local refs
* marking local refs as complete (part of the matching process)
Both of these stages can be slow for repositories with many refs.
Signed-off-by Erik Chen [email protected] [[email protected]]
Erik Chen (1):
fetch: add trace2 instrumentation
fetch-pack.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
base-commit: d9f6f3b6195a0ca35642561e530798ad1469bd41
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-451%2Ferikchen%2Ftest12-v5
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-451/erikchen/test12-v5
Pull-Request: https://github.com/gitgitgadget/git/pull/451
Range-diff vs v4:
1: 508d07a3eb ! 1: d7bf1849ce fetch: add trace2 instrumentation
@@ -5,12 +5,11 @@
Add trace2 regions to fetch-pack.c to better track time spent in the various
phases of a fetch:
- * matching common remote and local refs
* parsing remote refs and finding a cutoff
* marking local refs as complete
* marking complete remote refs as common
- Both of these stages can be slow for repositories with many refs.
+ All stages could potentially be slow for repositories with many refs.
Signed-off-by: Erik Chen <[email protected]>
@@ -21,8 +20,6 @@
save_commit_buffer = 0;
-+ trace2_region_enter("fetch-pack", "mark_complete_and_common_ref", NULL);
-+
+ trace2_region_enter("fetch-pack", "parse_remote_refs_and_find_cutoff", NULL);
for (ref = *refs; ref; ref = ref->next) {
struct object *o;
@@ -72,7 +69,4 @@
+ trace2_region_leave("fetch-pack", "mark_common_remote_refs", NULL);
save_commit_buffer = old_save_commit_buffer;
-+ trace2_region_leave("fetch-pack", "mark_complete_and_common_ref", NULL);
}
-
- /*Signature · 1 line
gitgitgadget