Skip to content

add--interactive: skip index refresh in reset patch mode

Nika Layzell via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1add--interactive: skip index refresh in reset patch modegit-add--interactive.perl+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] add--interactive: skip index refresh in reset patch mode

The refresh command is called from git-add--interactive to ensure that git's view of the worktree is up-to-date. This is necessary for most commands which use git-add--interactive, as they are interacting with the worktree, however it's not necessary for git-reset, which exclusively operates on the index. This patch skips the refresh call when performing a git-reset -p, which can improve performance on large repositories which have out-of-date, or no, caches of the current worktree state.

I chose to use the existing FILTER property of the flavour to make this decision. A separate REFRESH property could be added instead.

Nika Layzell (1):
add--interactive: skip index refresh in reset patch mode

 git-add--interactive.perl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-475%2Fmystor%2Findex-only-refresh-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-475/mystor/index-only-refresh-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/475

Signature · 1 line
gitgitgadget