Graph horizontal fix
Status from this message: Queued. Thanks.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | graph: add test to demonstrate horizontal line bugt/ | +62 | 0 replies | |
| 2/2 | graph: fix collapse of multiple edgesgraph.c t/ | +9 | 3 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] Graph horizontal fix
This depends on ds/graph-assert-fix.
This is a non-critical (not needed for v2.25.0) response to the previous discussions [1] [2].
While working to resolve the fix for the assert() bug, I noticed this regression when multiple edges wanted to collapse with horizontal lines. It takes a reasonably large graph, but real projects are likely to demonstrate this behavior.
I arranged the series into two patches: 1. the (failing) test, and 2. the fix.
The fix commit includes some details about why the change to compress merge commits caused this regression, and why I feel relatively confident that this is a correct resolution.
Thanks, -Stolee
[1]
https://lore.kernel.org/git/[email protected]/T/#t
[2]
https://lore.kernel.org/git/[email protected]/T/#t
Derrick Stolee (2):
graph: add test to demonstrate horizontal line bug
graph: fix collapse of multiple edges
graph.c | 10 ++++-- t/t4215-log-skewed-merges.sh | 62 ++++++++++++++++++++++++++++++++++++ 2 files changed, 70 insertions(+), 2 deletions(-)
base-commit: aa2121af50498c7ea9d5c4c87f9dc66605bf772b
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-518%2Fderrickstolee%2Fgraph-horizontal-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-518/derrickstolee/graph-horizontal-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/518
Signature · 1 line
gitgitgadget