Skip to content

object.c: localize global the_repository variable into r

Parth Gala via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5object.c: get_max_object_index and get_indexed_object accept 'r' parameterbuiltin/fsck.c builtin/index-pack.c builtin/name-rev.c +4 more+27 -203 replies
2/5object.c: lookup_unknown_object() accept 'r' as parameterbuiltin/fsck.c builtin/pack-objects.c http-push.c +6 more+21 -146 replies
3/5object.c: parse_object_or_die() accept 'r' as parameterbuiltin/grep.c builtin/prune.c bundle.c +5 more+24 -140 replies
4/5object.c: clear_object_flags() accept 'r' as parameterbuiltin/log.c object.c object.h +3 more+11 -80 replies
5/5object.c: clear_commit_marks_all() accept 'r' as parameterbuiltin/checkout.c object.c object.h+6 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] object.c: localize global the_repository variable into r

I have created this commit in response to
https://github.com/gitgitgadget/git/issues/379#issue-503866117. All the functions in object.c which relied on 'the_repository' have been modified. The functions calling these functions in object.c consisted calls to other functions using 'the_repository' as well, and although I intended to use 'r' at all those instances, I thought it would make more sense when we would deal with their callee functions in another similar patch. What do you think ?

Parth Gala (5):
object.c: get_max_object_index and get_indexed_object accept 'r'
parameter
object.c: lookup_unknown_object() accept 'r' as parameter object.c: parse_object_or_die() accept 'r' as parameter object.c: clear_object_flags() accept 'r' as parameter object.c: clear_commit_marks_all() accept 'r' as parameter

 builtin/checkout.c               |  3 ++-
 builtin/fsck.c                   |  8 +++++---
 builtin/grep.c                   |  6 ++++--
 builtin/index-pack.c             |  5 +++--
 builtin/log.c                    |  3 ++-
 builtin/name-rev.c               |  5 +++--
 builtin/pack-objects.c           |  3 ++-
 builtin/prune.c                  |  3 ++-
 bundle.c                         |  8 +++++---
 http-push.c                      |  3 ++-
 object.c                         | 32 ++++++++++++++++----------------
 object.h                         | 12 ++++++------
 pack-bitmap.c                    |  5 +++--
 reachable.c                      |  6 ++++--
 refs.c                           |  3 ++-
 revision.c                       |  3 ++-
 shallow.c                        | 13 ++++++++-----
 t/helper/test-example-decorate.c |  7 ++++---
 upload-pack.c                    | 19 ++++++++++++-------
 walker.c                         |  3 ++-
 20 files changed, 89 insertions(+), 61 deletions(-)

base-commit: 0ad714499976290d9a0229230cbe4efae930b8dc
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-545%2FParthGala2k%2Flocalize-the_repository-variable-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-545/ParthGala2k/localize-the_repository-variable-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/545

Signature · 1 line
gitgitgadget