Skip to content

Explicitly fflush stdout in git clean

Johannes Schindelin via GitGitGadget git 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 0 repliesNew
  2. v22 patches 5 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Changes in v3 from the cover letter

* Fixed the capitalization of "THerefore" in the commit message.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Refactor code asking the user for input interactivelyadd-interactive.c add-patch.c builtin/clean.c +3 more+22 -160 replies
2/2Explicitly `fflush` stdout before expecting interactive inputprompt.c+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] Explicitly fflush stdout in git clean

This is yet another patch that was funneled through a Git for Windows PR,
read: it has been battle-tested.

Of course, the current iteration of this patch series has not been battle-tested, so please do review carefully, so that we can prevent bugs from slipping in during the review process.

Changes since v2:

* Fixed the capitalization of "THerefore" in the commit message.

Changes since v1:

* Added a preparatory patch that refactors all interactive input reading via strbuf_getline(..., stdin).
* Adjusted the patch and its commit message accordingly.

Johannes Schindelin (1):
Refactor code asking the user for input interactively

마누엘 (1):
Explicitly fflush stdout before expecting interactive input

 add-interactive.c |  4 ++--
 add-patch.c       |  4 ++--
 builtin/clean.c   | 14 ++++----------
 prompt.c          | 12 ++++++++++++
 prompt.h          |  2 ++
 shell.c           |  4 ++--
 6 files changed, 24 insertions(+), 16 deletions(-)

base-commit: 9fadedd637b312089337d73c3ed8447e9f0aa775
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-755%2Fdscho%2Ffflush-in-git-clean-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-755/dscho/fflush-in-git-clean-v3
Pull-Request: https://github.com/git/git/pull/755

Range-diff vs v2:

1: 9d2ee78a9e4 ! 1: 072f95090ae Refactor code asking the user for input interactively
@@ Commit message
beginning and at the end of the answer, instead of trimming only the end (as the caller in add-patch.c does).

- THerefore, technically speaking, we change behavior in this patch. At
+ Therefore, technically speaking, we change behavior in this patch. At
the same time, it can be argued that this is actually a bug fix.

2: d3949e42004 = 2: 063d2aaa401 Explicitly fflush stdout before expecting interactive input

Signature · 1 line
gitgitgadget