Skip to content

builtin/*: update usage format

阿德烈 via GitGitGadget git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 1 replySuperseded
  3. v11 patch 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2parse-options: format argh like error messagesparse-options.h+3 -30 replies
2/2builtin/*: update usage formatbuiltin/am.c builtin/blame.c builtin/commit-graph.c +4 more+61 -610 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchZheNing Hu
SeriesNoticed-by
1/2Noticed-by
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] builtin/*: update usage format

According to the "Error Messages" section of Documentation/CodingGuidelines, we should not end in a full stop or start with a capital letter. Fix old error and usage messages to match this expectation.

Junio C Hamano (1):
parse-options: format argh like error messages

ZheNing Hu (1):
builtin/*: update usage format

 builtin/am.c                |  4 ++--
 builtin/blame.c             | 48 ++++++++++++++++++-------------------
 builtin/commit-graph.c      |  6 ++---
 builtin/fast-export.c       | 22 ++++++++---------
 builtin/log.c               |  8 +++----
 builtin/shortlog.c          | 10 ++++----
 builtin/submodule--helper.c | 24 +++++++++----------
 parse-options.h             |  6 ++---
 8 files changed, 64 insertions(+), 64 deletions(-)

base-commit: 6d3ef5b467eccd2769f1aa1c555d317d3c8dc707
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-822%2Fadlternative%2Fdev-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-822/adlternative/dev-v3
Pull-Request: https://github.com/gitgitgadget/git/pull/822

Range-diff vs v2:

2: c5f01b0eab1 ! 1: 9d508df032b parse-options: format argh like error messages
@@ Commit message

+ Signed-off-by: ZheNing Hu <[email protected]>

## parse-options.h ##
@@ parse-options.h: typedef enum parse_opt_result parse_opt_ll_cb(struct parse_opt_ctx_t *ctx,
1: 52f7c8457dd ! 2: d3eb6dcff14 builtin/*: update usage format
@@ Metadata
## Commit message ##
builtin/*: update usage format

- According to the "Error Messages" section of
- Documentation/CodingGuidelines, we should not end in a full
- stop or start with a capital letter. Fix old error and usage
+ According to the guidelines in parse-options.h,
+ we should not end in a full stop or start with
+ a capital letter. Fix old error and usage
messages to match this expectation.

Signature · 1 line
gitgitgadget