Skip to content

Fix handling of matching nonbare repo vs. matching something under nonbare repo

Elijah Newren via GitGitGadget git 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2t3000: fix some test description typost/t3000-ls-files-others.sh+4 -40 replies
2/2dir: avoid prematurely marking nonbare repositories as matchesdir.c t/t3000-ls-files-others.sh+22 -30 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchKyle Meyer
1/2
2/2Simplified-testcase-and-bisection-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Fix handling of matching nonbare repo vs. matching something under nonbare repo

This fixes the issue reported at
https://lore.kernel.org/git/CADjceoQxoL932W4mkfhG6VOgrQBhs9k6tXkWSkraKVPmUP+uCw@mail.gmail.com/
, a regression in git-2.27.0 (that wasn't reported until after 2.28.0). It involves running ls-files --others with globs when nonbare repositories are present.

Thanks to christian w for reporting, and Kyle Meyer for finding a way to simplify the testcase and bisecting. Very helpful.

Elijah Newren (2):
t3000: fix some test description typos
dir: avoid prematurely marking nonbare repositories as matches

 dir.c                      |  9 ++++++---
 t/t3000-ls-files-others.sh | 24 ++++++++++++++++++++----
 2 files changed, 26 insertions(+), 7 deletions(-)

base-commit: 47ae905ffb98cc4d4fd90083da6bc8dab55d9ecc
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-829%2Fnewren%2Fls-files-wildmatch-nonbare-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-829/newren/ls-files-wildmatch-nonbare-v1
Pull-Request: https://github.com/git/git/pull/829

Signature · 1 line
gitgitgadget

Read the cover letter in its thread