cmake: learn to optionally skip linking dashed built-ins
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 0 repliesNew
- v14 patches 2 repliesSuperseded
Changes in v2 from the cover letter
* Use proper string/variable CMake syntax, as pointed out by Danh
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | cmake: support SKIP_DASHED_BUILT_INScontrib/ | +4 | 0 replies | |
| 2/4 | cmake(install): fix double .exe suffixescontrib/ | +2 | 0 replies | |
| 3/4 | cmake: add a preparatory work-around to accommodate `vcpkg`contrib/ | +9 | 0 replies | |
| 4/4 | cmake(install): include vcpkg dlls.github/ contrib/ | +9 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/4] cmake: learn to optionally skip linking dashed built-ins
In Git for Windows, we would like to make use of the fact that our CMake-based build can also install the files into their final location. This patch series helps with that.
Changes since v1:
* Use proper string/variable CMake syntax, as pointed out by Danh
Dennis Ameling (2):
cmake(install): fix double .exe suffixes
cmake(install): include vcpkg dlls
Johannes Schindelin (2):
cmake: support SKIP_DASHED_BUILT_INS
cmake: add a preparatory work-around to accommodate vcpkg
.github/workflows/main.yml | 5 +++++ contrib/buildsystems/CMakeLists.txt | 26 +++++++++++++++++++------- 2 files changed, 24 insertions(+), 7 deletions(-)
base-commit: 773e25afc41b1b6533fa9ae2cd825d0b4a697fad
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-887%2Fdscho%2Fskip-dashed-built-ins-in-cmake-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-887/dscho/skip-dashed-built-ins-in-cmake-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/887
Range-diff vs v1:
1: ff7e8121d7a4 = 1: ff7e8121d7a4 cmake: support SKIP_DASHED_BUILT_INS 2: 69856f278645 = 2: 69856f278645 cmake(install): fix double .exe suffixes 3: 543fd0f5d7e5 ! 3: 5d953a21e9bd cmake: add a preparatory work-around to accommodate `vcpkg`
@@ contrib/buildsystems/CMakeLists.txt: list(TRANSFORM git_shell_scripts PREPEND "$
#install
-install(TARGETS git git-shell
+foreach(program ${PROGRAMS_BUILT})
-+if(${program} STREQUAL git OR ${program} STREQUAL git-shell) ++if(program STREQUAL "git" OR program STREQUAL "git-shell")
+install(TARGETS ${program}
RUNTIME DESTINATION bin)
+else()
4: 4b183c7def58 = 4: f020cb517dfc cmake(install): include vcpkg dlls
Signature · 1 line
gitgitgadget