Skip to content

replace test -f with test_path_is_file

Krushnal Patel via GitGitGadget git 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v11 patch 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2replace test -f with test_path_is_filet/t7300-clean.sh+138 -1380 replies
2/2replaced test -f and test ! -ft/t7300-clean.sh+188 -1881 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] replace test -f with test_path_is_file

Although has the same functionality as test_path_is_file(), in the case where test_path_is_file() fails, we get much better debugging information.

Replace with test_path_is_file so that future developers will have a better experience debugging these test cases.

krush11 (2):
replace test -f with test_path_is_file
replaced test -f and test ! -f

 t/t7300-clean.sh | 376 +++++++++++++++++++++++------------------------
 1 file changed, 188 insertions(+), 188 deletions(-)

base-commit: 576ba9dcdaf1007243f5a5cb4bf1a1e7b8fcf850
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-982%2Fkrush11%2Fnext-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-982/krush11/next-v2
Pull-Request: https://github.com/git/git/pull/982

Range-diff vs v1:

 1:  e5f92e3882cd = 1:  e5f92e3882cd replace test -f with test_path_is_file
 -:  ------------ > 2:  a31a147a34f8 replaced test -f and test ! -f
Signature · 1 line
gitgitgadget