Skip to content

cat-file: reuse ref-filter logic

ZheNing Hu via GitGitGadget git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 23 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15ref-filter: add obj-type check in grab contentsref-filter.c+15 -90 replies
2/15ref-filter: add %(raw) atomDocumentation/git-for-each-ref.txt ref-filter.c t/t6300-for-each-ref.sh+337 -272 replies
3/15ref-filter: --format=%(raw) re-support --perlDocumentation/git-for-each-ref.txt quote.c quote.h +2 more+48 -82 replies
4/15ref-filter: use non-const ref_format in *_atom_parser()builtin/tag.c ref-filter.c ref-filter.h+25 -250 replies
5/15ref-filter: add %(rest) atomref-filter.c ref-filter.h t/t3203-branch-output.sh +3 more+41 -10 replies
6/15ref-filter: pass get_object() return value to their callersref-filter.c+11 -60 replies
7/15ref-filter: introduce free_ref_array_item_value() functionref-filter.c ref-filter.h+10 -30 replies
8/15ref-filter: add cat_file_mode in struct ref_formatref-filter.c ref-filter.h+10 -25 replies
9/15ref-filter: modify the error message and value in get_objectref-filter.c t/t6301-for-each-ref-errors.sh+3 -30 replies
10/15cat-file: add has_object_file() checkbuiltin/cat-file.c+7 -02 replies
11/15cat-file: change batch_objects parameter namebuiltin/cat-file.c+10 -100 replies
12/15cat-file: reuse ref-filter logicDocumentation/git-cat-file.txt builtin/cat-file.c t/t1006-cat-file.sh+304 -1957 replies
13/15cat-file: reuse err buf in batch_object_write()builtin/cat-file.c+14 -80 replies
14/15cat-file: re-implement --textconv, --filters optionsbuiltin/cat-file.c ref-filter.c ref-filter.h+65 -25 replies
15/15ref-filter: remove grab_oid() functionref-filter.c+9 -170 replies

Reviews trailers per patch

None of the 15 patches has a Reviewed-by or Acked-by.

PatchChristian CouderHariom VermaJunio C HamanoÆvar Arnfjörð BjarmasonBagas SanjayaFelipe ContrerasPhillip WoodOlga Telezhnaya
1/15Mentored-by Mentored-by Helped-by
2/15Mentored-by Mentored-by Helped-by Helped-by Helped-by Helped-by Helped-by Based-on-patch-by
3/15Helped-by
4/15Mentored-by Mentored-by
5/15Mentored-by Mentored-by
6/15Mentored-by Mentored-by Helped-by
7/15Mentored-by Mentored-by Helped-by
8/15Mentored-by Mentored-by
9/15Mentored-by Mentored-by
10/15Mentored-by Mentored-by
11/15Mentored-by Mentored-by
12/15Mentored-by Mentored-by
13/15Mentored-by Mentored-by
14/15Mentored-by Mentored-by
15/15Mentored-by Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v1 thread

Cover letter [PATCH 00/15] [GSOC] cat-file: reuse ref-filter logic

This patch series make cat-file reuse ref-filter logic.

Change from last version:

1. Amend part of the description of git for-each-ref.txt.
2. Modify commit messages about why cat-file reject some atoms.
3. Resolve conflicts with the 'seen' branch, rebase this patch on (bb9a3a8f77 Merge branch 'zh/cat-file-batch-fix' into jch).

ZheNing Hu (15):
[GSOC] ref-filter: add obj-type check in grab contents [GSOC] ref-filter: add %(raw) atom
[GSOC] ref-filter: --format=%(raw) re-support --perl [GSOC] ref-filter: use non-const ref_format in *_atom_parser() [GSOC] ref-filter: add %(rest) atom
[GSOC] ref-filter: pass get_object() return value to their callers [GSOC] ref-filter: introduce free_ref_array_item_value() function [GSOC] ref-filter: add cat_file_mode in struct ref_format [GSOC] ref-filter: modify the error message and value in get_object [GSOC] cat-file: add has_object_file() check
[GSOC] cat-file: change batch_objects parameter name [GSOC] cat-file: reuse ref-filter logic
[GSOC] cat-file: reuse err buf in batch_object_write() [GSOC] cat-file: re-implement --textconv, --filters options [GSOC] ref-filter: remove grab_oid() function

 Documentation/git-cat-file.txt     |   6 +
 Documentation/git-for-each-ref.txt |   9 +
 builtin/cat-file.c                 | 275 ++++++----------------
 builtin/tag.c                      |   2 +-
 quote.c                            |  17 ++
 quote.h                            |   1 +
 ref-filter.c                       | 357 ++++++++++++++++++++++-------
 ref-filter.h                       |  14 +-
 t/t1006-cat-file.sh                | 251 ++++++++++++++++++++
 t/t3203-branch-output.sh           |   4 +
 t/t6300-for-each-ref.sh            | 235 +++++++++++++++++++
 t/t6301-for-each-ref-errors.sh     |   2 +-
 t/t7004-tag.sh                     |   4 +
 t/t7030-verify-tag.sh              |   4 +
 14 files changed, 887 insertions(+), 294 deletions(-)

base-commit: bb9a3a8f77e13b7a414cf64bf294c3f59f2444c9
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-989%2Fadlternative%2Fcat-file-batch-refactor-rebase-version-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-989/adlternative/cat-file-batch-refactor-rebase-version-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/989

Signature · 1 line
gitgitgadget

Read the cover letter in its thread