smp_call_function_many issues from review
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 9 repliesIn review
- v22 of 3 patches 8 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | call_function_many: fix list delete vs add racekernel/ | +13 | 0 replies | |
| 2/4 | call_function_many: add missing orderingkernel/ | +33 | 1 reply | |
| 3/4 | smp_call_function_many: handle concurrent clearing of maskkernel/ | +10 | 2 replies | |
| 4/4 | smp_call_function_interrupt: use typedef and %pfkernel/ | +8 | 0 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Peter Zijlstra | Jan Beulich |
|---|---|---|
| Series | A-b | |
| 1/4 | ||
| 2/4 | ||
| 3/4 | A-b | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4 v3] smp_call_function_many issues from review
Picking up this thread from the beginning of Feburary, I updated the comments in 3 and 4 based on Paul's review. I have inserted my proposed alternative to Paul's additional patch as patch 2, and tweaked the changelog on 1.
[PATCH 1/4 v3] call_function_many: fix list delete vs add race [PATCH 2/4 v3] call_function_many: add missing ordering [PATCH 3/4 v3] smp_call_function_many: handle concurrent clearing of mask [PATCH 4/4 v3] smp_call_function_interrupt: use typedef and %pf
Peter Z acked a prior version of patch 1, and Mike Galbraith has done some stress testing on the combinaton of 1,3,4, and Paul's patch.
The prior posting of this series is available here:
https://patchwork.kernel.org/patch/522021/
https://patchwork.kernel.org/patch/522031/
http://marc.info/?l=linux-kernel&m=129654439817236&w=2
And Paul's additional patch from review was here
https://patchwork.kernel.org/patch/525891/
Looking forward, I would suggest 1 and 2 are required for stable, 3 may be suitable as it fixes races that otherwise requires cpumask copies as in 75c1c91cb92806f960fcd6e53d2a0c21f343081c ([IA64] eliminate race condition in smp_flush_tlb_mm). By contrast 4 is just comments except for the %pS to %pf change.
Dimitri or Tony, let me know if you would like a revert patch for 75c1c91c to be added after patch 3.
milton