Skip to content

firewire: cope with temporary connection loss

Stefan Richter lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4firewire: keep highlevel drivers attached during brief connection lossdrivers/firewire/fw-device.c drivers/firewire/fw-device.h+100 -220 replies
2/4firewire: core: clean up includesdrivers/firewire/fw-device.c drivers/firewire/fw-device.h+22 -110 replies
3/4firewire: core: move some functionsdrivers/firewire/fw-device.c+44 -460 replies
4/4firewire: core: remove condition which is always falsedrivers/firewire/fw-device.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] firewire: cope with temporary connection loss

In the following series, the 1st patch enables the firewire stack to tolerate brief disappearance of nodes similarly as the ieee1394 stack has been taught in Linux 2.6.28.

This finally allows me to push the patch
Date: Wed, 19 Mar 2008 22:02:40 +0100 (CET)
From: Stefan Richter <[email protected]>
Subject: firewire: insist on successive self ID complete events
into the mainline, which is a fix that potentially prevents kernel panics. This fix had the unfortunate side effect that the firewire-core topology code destroyed and re-created node representations more often than before. Until now, this caused high-level drivers (firewire-sbp2 and userspace drivers) to be unbound and rebound, so that for example mounted filesystems were lost.

Besides the condition which triggered the "insist on successive self ID complete events" precautions, there are also other occasions at which nodes vanish briefly and reappear. See the changelog of patch 1/4. firewire-core is now able to keep drivers bound until the nodes come back, if they come back quickly.

The latter 3 patches are cleanups.

[PATCH 1/4] firewire: keep highlevel drivers attached during brief connection loss [PATCH 2/4] firewire: core: clean up includes
[PATCH 3/4] firewire: core: move some functions
[PATCH 4/4] firewire: core: remove condition which is always false

 drivers/firewire/fw-device.c |  231 +++++++++++++++++++++++------------
 drivers/firewire/fw-device.h |   14 +-
 2 files changed, 166 insertions(+), 79 deletions(-)
Signature · 3 lines
Stefan Richter
-=====-==--= ---= =---=
http://arcgraph.de/sr/