Skip to content

firewire: endinaness warnings (was Re: sparse - make __CHECK_ENDIAN__ default enabled?)

Stefan Richter linuxppc-dev lkml sparclinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2firewire: endianess fixdrivers/firewire/fw-ohci.c+1 -125 replies
2/2firewire: endianess annotationsdrivers/firewire/fw-ohci.c drivers/firewire/fw-transaction.c drivers/firewire/fw-transaction.h+6 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] firewire: endinaness warnings (was Re: sparse - make __CHECK_ENDIAN__ default enabled?)

On 20 Feb, Harvey Harrison wrote on LKML:

Quoted 8 lines · Sam Ravnborg
Quoted 6 lines

Hi Harvey.

Can I ask you to look into the worst offenders so we can make -D__CHECK_ENDIAN__ enabled per default in the kernel.
Or maybe we should do it anyway?

Quoted 6 lines

Well, I've got the worst of fs and drivers/ata done so far, still weeping over the 5500 warnings in drivers. (X86_32 allyesconfig). People ignore the existing warnings anyway, why not toss a few more on the pile?

I'll look them over tonight and see how bad it would be.

I looked into drivers/firewire and drivers/ieee1394. As expected, there are quite a lot endianess related warnings in the latter because this is code from way before sparse was regularly used.

There are also a few warnings in the former, even though sparse checks were run before submission of the whole drivers/firewire stack. I will follow up with two patches:
1/2 firewire: endianess fix
2/2 firewire: endianess annotations
Whether the "fix" is really a fix remains to be seen; I don't have a big endian Linux box myself.

Signature · 2 lines
Stefan Richter
-===-=--- --=- =-=http://arcgraph.de/sr/