Skip to content

ieee1394: ohci1394: endianess bug in verbose debug log

Stefan Richter lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ieee1394: ohci1394: fix endianess bug in debug messagedrivers/ieee1394/ohci1394.c+1 -10 replies
2/2ieee1394: ohci1394: more obvious endianess handlingdrivers/ieee1394/ohci1394.c+13 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] ieee1394: ohci1394: endianess bug in verbose debug log

This fixes a debug macro on some big endian machines. Related code is touched up too to make it harder to introduce such bugs in the future.

- ieee1394: ohci1394: fix endianess bug in debug message
- ieee1394: ohci1394: more obvious endianess handling

Wolfgang, could you test and send an ACK? The tlabel in each "Packet received from node" message should match that of the previous "Packet sent to node" line. Example of a wrong log:
http://www.wolfgangpfeiffer.com/disable-irm.kern.log.when.fw.disk.is.switched.on.txt
The received tlabel was always 48 on this Apple AluBook 5,8.

Signature · 3 lines
Stefan Richter
-=====-=-==- =--= -=---
http://arcgraph.de/sr/