Skip to content

"rerere" preparatory clean-up

Junio C Hamano git 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest18 patches 6 repliesIn review
  2. v213 patches 0 repliesSuperseded
  3. v11 patch 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18rerere: fix an off-by-one non-bugrerere.c+2 -41 reply
2/18rerere: plug conflict ID leaksrerere.c+5 -20 replies
3/18rerere: lift PATH_MAX limitationrerere.c+15 -200 replies
4/18rerere: write out each record of MERGE_RR in one gorerere.c+9 -70 replies
5/18rerere: report autoupdated paths only after actually updating themrerere.c+12 -100 replies
6/18rerere: drop want_sp parameter from is_cmarker()rerere.c+22 -52 replies
7/18rerere: stop looping unnecessarilyrerere.c+7 -101 reply
8/18rerere: explain the rerere I/O abstractionrerere.c+31 -71 reply
9/18rerere: explain MERGE_RR management helpersrerere.c+41 -00 replies
10/18rerere: explain the primary codepathrerere.c+82 -130 replies
11/18rerere: explain "rerere forget" codepathrerere.c+24 -00 replies
12/18rerere: explain the remainderrerere.c+20 -00 replies
13/18rerere: refactor "replay" part of do_plain_rerere()rerere.c+40 -350 replies
14/18rerere: further de-dent do_plain_rerere()rerere.c+35 -340 replies
15/18rerere: further clarify do_rerere_one_path()rerere.c+6 -90 replies
16/18rerere: call conflict-ids IDsbuiltin/rerere.c rerere.c rerere.h+41 -410 replies
17/18rerere: use "struct rerere_id" instead of "char *" for conflict IDbuiltin/rerere.c rerere.c rerere.h+85 -281 reply
18/18rerere: un-nest merge() furtherrerere.c+26 -240 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/18] "rerere" preparatory clean-up

This is a resend of v2:

    http://thread.gmane.org/gmane.comp.version-control.git/273117

plus 5 new changes. I have a few more real-fix changes that build on top, but they are not sufficiently polished to be published yet compared to these early clean-up bits.

Junio C Hamano (18):
rerere: fix an off-by-one non-bug
rerere: plug conflict ID leaks
rerere: lift PATH_MAX limitation
rerere: write out each record of MERGE_RR in one go
rerere: report autoupdated paths only after actually updating them
rerere: drop want_sp parameter from is_cmarker()
rerere: stop looping unnecessarily
rerere: explain the rerere I/O abstraction
rerere: explain MERGE_RR management helpers
rerere: explain the primary codepath
rerere: explain "rerere forget" codepath
rerere: explain the remainder
rerere: refactor "replay" part of do_plain_rerere()
rerere: further de-dent do_plain_rerere()
rerere: further clarify do_rerere_one_path()
rerere: call conflict-ids IDs
rerere: use "struct rerere_id" instead of "char *" for conflict ID
rerere: un-nest merge() further

 builtin/rerere.c |   4 +-
 rerere.c         | 544 ++++++++++++++++++++++++++++++++++++++++---------------
 rerere.h         |  12 +-
 3 files changed, 407 insertions(+), 153 deletions(-)
Signature · 1 line
2.5.0-rc2-340-g0cccc16