Fixes for gapped scatters
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 of 3 patches 0 repliesNew
1 of 3 patches is in this archive. The cover letter announces 3.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 3/3 | block: Refuse adding appending a gapped integrity page to a bio | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] Fixes for gapped scatters
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Sagi" == Sagi Grimberg <sagig at mellanox.com> writes:
Sagi> This small set addresses some issues with gapped scattered Sagi> IOs. The motivation of this is to have the iser driver take Sagi> advantage of it too.
Sagi> Patch 1 prevent gapped SG_IO if the driver can't handle gaps. Sagi> Patches 2,3 prevent gapped integrity payloads (for drivers that Sagi> support data integrity).
Back in the prototyping days of DIX we dealt with several controllers that had various oddball scatterlist requirements for PI. The only workaround we found that performed acceptably was to grab a page and bounce the PI to that. In the end none of these controllers ended up shipping, and DIX explicitly requires a controller to be able to handle a separate scatterlist element per PI interval.
I know that for NVMe latency is king and so on. But I do question the sanity of having to issue a flurry 512+8 I/Os instead of quarter of a meg and a page of PI. You're at the whim of the kernel memory allocator and for a long time slab or slub was allocating backwards so you never ended up being able to merge PI scatterlist entries.
Also, if you were to go down this path you'd have to handle cases where a bio itself would need to get split. The PI for two contiguous 512-byte data blocks in a bio_vec entry could reside in separate integrity pages at offsets that would make them "gappy".
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering