ARM: perf: split up perf_event.c by architecture
A message that is not in the archive (sent off-list or not yet received): -6296264039105571970@unknownmsgid
PATCH v2 1/1 ARM: perf: split up perf_event.c by architecture
Hi Will,
Quoted 19 lines · Will Deacon
Hello,
This is version 2 of the patches originally posted here:
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-November/031503.html
The only patch that has changed is 5/5 which addresses some style comments raised by Jean. Since the patch is over 100k, I've put it in my git repository rather than posting it to the list (where it would be held for moderation).
Feedback welcome.
The following changes since commit
3561d43fd289f590fdae672e5eb831b8d5cf0bf6:
?Linus Torvalds (1):
? ? ? ?Linux 2.6.37-rc3are available in the git repository at:
Quoted 8 lines
?git://linux-arm.org/linux-2.6-wd.git perf-split
Will Deacon (5):
? ? ?ARM: perf: consolidate common PMU behaviour
? ? ?ARM: perf: avoid exposing internal stop function for v6 PMU ? ? ?ARM: perf: add_init()functions to PMUs
? ? ?ARM: perf: encode PMU name inarm_pmustructure
? ? ?ARM: perf: separate PMU backends into multiple files
About the patch 5/5:
This probably is nitpicking from my side, but there still are warnings generated by checkpatch:
WARNING: please, no space before tabs
#3999: FILE: arch/arm/kernel/perf_event_xscale.c:9:
+ * ^I- xscale1pmu: 2 event counters and a cycle counter$
WARNING: please, no space before tabs
#4000: FILE: arch/arm/kernel/perf_event_xscale.c:10:
+ * ^I- xscale2pmu: 4 event counters and a cycle counter$
total: 0 errors, 2 warnings, 4754 lines checked
Other than that, nice work!
Thanks,
Jean
Quoted 18 lines
?arch/arm/kernel/perf_event.c ? ? ? ?| 2448 +---------------------------------- ?arch/arm/kernel/perf_event_v6.c ? ? | ?672 ++++++++++ ?arch/arm/kernel/perf_event_v7.c ? ? | ?906 +++++++++++++ ?arch/arm/kernel/perf_event_xscale.c | ?807 ++++++++++++?4 files changed, 2419 insertions(+), 2414 deletions(-) ?create mode 100644
arch/arm/kernel/perf_event_v6.c?create mode 100644arch/arm/kernel/perf_event_v7.c?create mode 100644arch/arm/kernel/perf_event_xscale.c_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 1/1 ARM: perf: split up perf_event.c by architecture
Hi Jean,
Quoted 9 lines
About the patch 5/5:
This probably is nitpicking from my side, but there still are warnings generated by checkpatch:
WARNING: please, no space before tabs
#3999: FILE:arch/arm/kernel/perf_event_xscale.c:9:
+ * ^I- xscale1pmu: 2 event counters and a cycle counter$
Quoted 5 lines
WARNING: please, no space before tabs
#4000: FILE:arch/arm/kernel/perf_event_xscale.c:10:
+ * ^I- xscale2pmu: 4 event counters and a cycle counter$total: 0 errors, 2 warnings, 4754 lines checked
These are in comments though so I'm not sure the coding-style rules apply. I can change it if if *really* annoys you though :)
Quoted 3 lines
Other than that, nice work!
Acked-by Jean Pihet <[email protected]>
Great, thanks! The hard part is going to be getting this merged without breaking any pending patches to perf_event.c. I think we're alright at the moment for 2.6.38 but if you see any patches getting scheduled that touch the old code, please let me know.
Will
A message that is not in the archive (sent off-list or not yet received): 8976531311637671749@unknownmsgid
PATCH v2 1/1 ARM: perf: split up perf_event.c by architecture
Will,
Quoted 11 lines · Will Deacon
Hi Jean,
Quoted 9 lines
About the patch 5/5:
This probably is nitpicking from my side, but there still are warnings generated by checkpatch:
WARNING: please, no space before tabs
#3999: FILE:arch/arm/kernel/perf_event_xscale.c:9:
+ * ^I- xscale1pmu: 2 event counters and a cycle counter$
Quoted 8 lines
Quoted 5 lines
WARNING: please, no space before tabs
#4000: FILE:arch/arm/kernel/perf_event_xscale.c:10:
+ * ^I- xscale2pmu: 4 event counters and a cycle counter$total: 0 errors, 2 warnings, 4754 lines checked
These are in comments though so I'm not sure the coding-style rules apply. I can change it if if *really* annoys you though :)
Not at all! checkpatch is useful but can be annoying at times.
Quoted 9 lines
Quoted 4 lines
Other than that, nice work!
Acked-by Jean Pihet <[email protected]>Great, thanks! The hard part is going to be getting this merged without breaking any pending patches to
perf_event.c. I think we're alright at the moment for 2.6.38 but if you see any patches getting scheduled that touch the old code, please let me know.
Ok will do!
Thanks,
Jean
Quoted 6 lines
Will