clean up unused kiocb variables
PATCH 1/1 clean up unused kiocb variables
Any reason why we keep these two variables around for kiocb structure? They are not used anywhere.
Patch to tidy up kiocb structure.
include/linux/aio.h renamed from include/linux/aio.h.orig +0 -2
@@ -110,8 +110,6 @@char __user *ki_buf;/* remaining iocb->aio_buf */ size_t ki_left;/* remaining bytes */ long ki_retried;/* just for testing */ -long ki_kicked;/* just for testing */ -long ki_queued;/* just for testing */ struct list_head ki_list;/* the aio core uses this * for cancellation */
Quoted 1 line · Kenneth W
Any reason why we keep these two variables around for kiocb structure?
If there is a good one I've forgotten it.
Quoted 1 line
They are not used anywhere.
Indeed.
The ki_retried users all seem pretty questionable, too. How about removing all that stuff?
Quoted 1 line
Signed-off-by Ken Chen <[email protected]>
- z
Zach Brown wrote on Thursday, September 21, 2006 12:34 PM
Quoted 8 lines
Quoted 1 line · Kenneth W
Any reason why we keep these two variables around for kiocb structure?
If there is a good one I've forgotten it.
Quoted 1 line
They are not used anywhere.
Indeed.
Let's remove them. We can always add them back if there is a need.
Quoted 2 lines
The
ki_retriedusers all seem pretty questionable, too. How about removing all that stuff?
Suparna wanted them around for debug purpose at one point. I don't know whether that is still the case right now. At least I can wrap it around with #if DEBUG.
- Ken
Quoted 2 lines
Let's remove them. We can always add them back if there is a need.
Agreed, especially in this age of dynamic probing.
Quoted 3 lines
Suparna wanted them around for debug purpose at one point. I don't know whether that is still the case right now. At least I can wrap it around with #if DEBUG.
I guess that's better than nothing. Given the near total lack of -EIOCBRETRY users I'm just not convinced that they're worth it.
- z